GNOME Bugzilla – Bug 786940
::icon-pressed handler stays connected when setting :show-emoji-icon to FALSE
Last modified: 2017-08-28 23:43:14 UTC
We should disconnect the handler and hide the icon. Otherwise, a user seems to have no way to change their secondary icon to do something else, without it still firing pick_emoji() and bringing up the chooser.
Created attachment 358627 [details] [review] Entry: Drop redundant typecasts
Created attachment 358628 [details] [review] Entry: Handle :show-emoji-icon becoming false Disconnect the now-unwanted signal handler, and hide the icon.
Also, when setting the secondary icon from the outside world, :show-emoji-icon should be forced off, so that the handler gets disconnected if a user doesn't realise/remember that they need to set it to FALSE manually before setting their new icon.
Attachment 358627 [details] pushed as cb21947 - Entry: Drop redundant typecasts Attachment 358628 [details] pushed as 896f7c8 - Entry: Handle :show-emoji-icon becoming false
(In reply to Daniel Boles from comment #3) > Also, when setting the secondary icon from the outside world, > :show-emoji-icon should be forced off, so that the handler gets disconnected > if a user doesn't realise/remember that they need to set it to FALSE > manually before setting their new icon. I didn't bother with this; it seems too complex for little reward. (Plus, maybe someone wants to have the emoji picker but with a different icon than our default...) So, for now, anyone who wants to change from the emoji icon to a normal one - which is probably an unlikely scenario anyway - will need to set :show-emoji-icon to FALSE as an essential part of that process.