After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786887 - multilib issue in pango-enum-types.h when building with meson
multilib issue in pango-enum-types.h when building with meson
Status: RESOLVED FIXED
Product: pango
Classification: Platform
Component: general
1.40.x
Other Linux
: Normal normal
: ---
Assigned To: pango-maint
pango-maint
Depends on:
Blocks:
 
 
Reported: 2017-08-28 09:24 UTC by Akira TAGOH
Modified: 2017-08-30 14:19 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed patch (722 bytes, patch)
2017-08-29 11:00 UTC, Akira TAGOH
committed Details | Review

Description Akira TAGOH 2017-08-28 09:24:35 UTC
there are two issues regarding to the multilib when building pango with meson. one is, the timestamp because meson always tries to regenerate pango-enum-types.[ch]. generated files should has same one to the original for a workaround.
another one is pango-enum-types.h contains environment specific context where @filename@ is replaced by.
Comment 1 Matthias Clasen 2017-08-28 17:10:41 UTC
I would suggest to simply remove those @filename@ comments - they don't really add much and, as you say, mess up multilib
Comment 2 Akira TAGOH 2017-08-29 10:52:59 UTC
sure. or replacing @filename@ with @basename@ may helps too?
Comment 3 Akira TAGOH 2017-08-29 11:00:36 UTC
Created attachment 358670 [details] [review]
proposed patch
Comment 4 Matthias Clasen 2017-08-30 12:04:25 UTC
Review of attachment 358670 [details] [review]:

sure