After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786885 - Add explanatory tooltip to emoji icon
Add explanatory tooltip to emoji icon
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkEntry
3.22.x
Other All
: Normal enhancement
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2017-08-28 07:36 UTC by Daniel Boles
Modified: 2017-09-01 21:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Entry: Set explanatory tooltip on emoji icon (912 bytes, patch)
2017-08-28 19:30 UTC, Daniel Boles
none Details | Review
Entry: Set tooltip text on icon for emoji chooser (1.37 KB, patch)
2017-08-29 12:00 UTC, Daniel Boles
none Details | Review
Entry: Set tooltip text on icon for emoji chooser (1.37 KB, patch)
2017-08-30 11:49 UTC, Daniel Boles
committed Details | Review

Description Daniel Boles 2017-08-28 07:36:40 UTC
The secondary icon is set to a smile emoji, and clicking it shows the emoji entry popover. It'd be good to set a tooltip on the icon to clarify what it'll do if clicked.

Also, shouldn't set_show_emoji_icon() unset the icon when FALSE? Currently it seems to be a one-way change in reality: https://git.gnome.org/browse/gtk+/tree/gtk/gtkentry.c?h=gtk-3-22#n11067

However, unsetting the tooltip will run into https://bugzilla.gnome.org/show_bug.cgi?id=785672 unless worked around.
Comment 1 Daniel Boles 2017-08-28 08:36:12 UTC
(In reply to Daniel Boles from comment #0)
> However, unsetting the tooltip will run into
> https://bugzilla.gnome.org/show_bug.cgi?id=785672 unless worked around.

other way round: unsetting the entry tooltip will hide those of the icons, but setting icon tooltips doesn't harm the main one anymore
Comment 2 Daniel Boles 2017-08-28 19:30:07 UTC
Created attachment 358624 [details] [review]
Entry: Set explanatory tooltip on emoji icon
Comment 3 Daniel Boles 2017-08-29 00:25:57 UTC
Review of attachment 358624 [details] [review]:

Since https://git.gnome.org/browse/gtk+/commit/?h=gtk-3-22&id=669e8c4de578f174a48f39f4a1a5bc1bfaf758b5 this should also unset the tooltip-text for the icon.
Comment 4 Piotr Drąg 2017-08-29 02:01:32 UTC
+                                       "Emoji Chooser");

This should be translatable, of course.
Comment 5 Daniel Boles 2017-08-29 10:47:32 UTC
Of course! Thanks for the eagle eye, as always. :)

I've got an updated patch, with some nice cleanups we can apply before it.

In the meantime, I wasn't sure about the tooltip - whether to say
  Emoji
  Emoji Chooser
  Emoji Picker
and also whether to capitalise the 2nd word (though I think this is correct).

So if anyone has any preferred text to use, I'd appreciate suggestions.
Comment 6 Daniel Boles 2017-08-29 12:00:39 UTC
Created attachment 358677 [details] [review]
Entry: Set tooltip text on icon for emoji chooser
Comment 7 Matthias Clasen 2017-08-30 11:45:42 UTC
I would suggest to make the tooltip the same as the menitem: "Insert Emoji"
Comment 8 Daniel Boles 2017-08-30 11:49:03 UTC
Created attachment 358751 [details] [review]
Entry: Set tooltip text on icon for emoji chooser

Oh yeah, of course.
Comment 9 Matthias Clasen 2017-09-01 21:28:54 UTC
Attachment 358751 [details] pushed as 7a3548e - Entry: Set tooltip text on icon for emoji chooser