After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786859 - Wrong check for libm in meson.build
Wrong check for libm in meson.build
Status: RESOLVED OBSOLETE
Product: gnome-software
Classification: Applications
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: GNOME Software maintainer(s)
GNOME Software maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-08-27 12:35 UTC by Christophe Fergeau
Modified: 2018-01-24 17:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (1.02 KB, patch)
2017-08-27 12:35 UTC, Christophe Fergeau 		committed Details | Review

Description Christophe Fergeau 2017-08-27 12:35:43 UTC 
Created attachment 358510 [details] [review]
Proposed patch

The test should be:
diff --git a/meson.build b/meson.build
index 099ffc18..544f40e2 100644
--- a/meson.build
+++ b/meson.build
@@ -98,7 +98,7 @@ gio_unix = dependency('gio-unix-2.0')
 gmodule = dependency('gmodule-2.0')
 gtk = dependency('gtk+-3.0', version : '>= 3.20.0')
 json_glib = dependency('json-glib-1.0', version : '>= 1.1.1')
-libm = cc.find_library('libm', required: false)
+libm = cc.find_library('m', required: false)
 libsecret = dependency('libsecret-1')
 libsoup = dependency('libsoup-2.4', version : '>= 2.51.92')
 sqlite3 = dependency('sqlite3')

otherwise meson checks for liblibm, which does not exist.
Comment 1 Richard Hughes 2017-08-27 19:58:43 UTC 
Comment on attachment 358510 [details] [review]
Proposed patch

Looks fine, please just commit obviously correct things like this without asking -- I'm pretty chilled out :) Thanks dude.
Comment 2 Christophe Fergeau 2017-08-28 07:42:36 UTC 
Sure, I'll try to remember that in the future ;)
Comment 3 GNOME Infrastructure Team 2018-01-24 17:44:30 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-software/issues/219.