After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786843 - Out of source build support
Out of source build support
Status: RESOLVED DUPLICATE of bug 725497
Product: vala
Classification: Core
Component: general
unspecified
Other All
: Normal minor
: ---
Assigned To: Vala maintainers
Vala maintainers
Depends on:
Blocks:
 
 
Reported: 2017-08-26 16:27 UTC by Jakub Kaszycki
Modified: 2017-08-26 19:42 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement

Attachments
This patch makes the Makefiles (and valadoc/tests/testrunner.sh) work properly in a separate builddir (15.53 KB, patch)
2017-08-26 16:28 UTC, Jakub Kaszycki 		none Details | Review
This patch makes the .version be generated in builddir, not srcdir (1.12 KB, patch)
2017-08-26 16:29 UTC, Jakub Kaszycki 		none Details | Review

Description Jakub Kaszycki 2017-08-26 16:27:03 UTC 
Currently, Vala source code is not suitable for out-of-source builds. The programmers mix up srcdir and builddir.

It looks like their knowledge of the meaning of srcdir and builddir came from Automake. Vala does not use Automake's built-in Vala rules, it uses custom ones that store .c files in builddir.

I have already prepared a patch, that allows me to run configure with a separate builddir. By moving .version from top_srcdir to top_builddir, this allows me even to make the srcdir read-only.

The patches are made for the current state of the master branch (26 August 2017).
Comment 1 Jakub Kaszycki 2017-08-26 16:28:24 UTC 
Created attachment 358488 [details] [review]
This patch makes the Makefiles (and valadoc/tests/testrunner.sh) work properly in a separate builddir
Comment 2 Jakub Kaszycki 2017-08-26 16:29:07 UTC 
Created attachment 358489 [details] [review]
This patch makes the .version be generated in builddir, not srcdir
Comment 3 Rico Tzschichholz 2017-08-26 16:54:21 UTC 
Take a look at https://bugzilla.gnome.org/show_bug.cgi?id=725497
Comment 4 Jakub Kaszycki 2017-08-26 19:42:30 UTC 

*** This bug has been marked as a duplicate of bug 725497 ***