GNOME Bugzilla – Bug 786833
No translations are used
Last modified: 2017-09-11 19:15:41 UTC
My localization is ignored and even running > LANG=fur_IT.UTF-8 bijiben from terminal it's still in english previous version as I remember were ok
What is your distribution and the exact version?
I can confirm with bijiben-3.24.1-1.fc26.x86_64 — it’s always in English, regardless of locale.
Fedora 26 Bijiben 3.24.0
I confirm that too for Bijigen 3.24.1 in Arch Linux, except for the initial note, "About" and "Credits" buttons in the About dialog, and the app name in top bar - these are localized.
Created attachment 358915 [details] [review] build: use AM_GLIB_GNU_GETTEXT for translations This issue was introduced by commit 4fadc068a21528b1e07970132648d4a067289929.
Review of attachment 358915 [details] [review]: Tested, it successfully restores the translated interface.
Review of attachment 358915 [details] [review]: Hi Jonathan, thanks for your patch. As pointed out by sadic in #bijiben channel, according to [1] you need to change AM_GNU_GLIB_GETTEXT by AM_GNU_GETTEXT. Please do the change and we should be good. I would also ask you to be more verbose about the issue and the solution. Please review [2]. [1] https://wiki.gnome.org/MigratingFromIntltoolToGettext [2] https://wiki.gnome.org/Git/CommitMessages
(In reply to Isaque Galdino from comment #7) > Review of attachment 358915 [details] [review] [review]: > > Hi Jonathan, thanks for your patch. > > As pointed out by sadic in #bijiben channel, according to [1] you need to > change AM_GNU_GLIB_GETTEXT by AM_GNU_GETTEXT. > Please do the change and we should be good. > I would also ask you to be more verbose about the issue and the solution. > Please review [2]. > > [1] https://wiki.gnome.org/MigratingFromIntltoolToGettext > [2] https://wiki.gnome.org/Git/CommitMessages for any user who needs a quick-fix, please use the above patch. Jonathan is working in a permanent solution.
Created attachment 359429 [details] [review] Migrate from intltool to gettext
Can we push the “quick fix” and make Bijiben usable again to the majority of our users first, and then worry about overhauling the whole i18n infrastructure?
Review of attachment 359429 [details] [review]: Patch seems to be working fine in my system.
Review of attachment 359429 [details] [review]: • I can’t think of a reason to allow disabling i18n (USE_NLS). • .loc file that should accompany the .its file is missing, and no other app uses an intermediary .pot file for this. • ABOUT-NLS and po/org.gnome.bijiben.pot shouldn’t be in version control. • Updating .po files is unneeded — it’s translators’ job. I also repeat my request to push the fix (not this patch, which actually belongs to a separate bug) to gnome-3-24 and release 3.24.2 ASAP.
(In reply to Piotr Drąg from comment #12) > I also repeat my request to push the fix (not this patch, which actually > belongs to a separate bug) to gnome-3-24 and release 3.24.2 ASAP. https://bugzilla.gnome.org/show_bug.cgi?id=786461 is about migrating from intltool to gettext. This bug is a serious regression that I would consider a blocker, and we have a one-line patch to fix it, ready and tested.
(In reply to Piotr Drąg from comment #12) > Review of attachment 359429 [details] [review] [review]: > > • .loc file that should accompany the .its file is missing, and no other app > uses an intermediary .pot file for this. In the wip meson branch[0], as I also moved it from intltool to gettext, I have also created a mime.its[1] (which is a bit different) and a mime.loc[2] file which could help with this issue. I hope they[1][2] are correct though, [0] https://git.gnome.org/browse/bijiben/log/?h=wip/inigomartinez/meson [1] https://git.gnome.org/browse/bijiben/tree/gettext/its/mime.its?h=wip/inigomartinez/meson [2] https://git.gnome.org/browse/bijiben/tree/gettext/its/mime.loc?h=wip/inigomartinez/meson
Review of attachment 358915 [details] [review]: work-around pushed to master.
(In reply to Piotr Drąg from comment #12) > Review of attachment 359429 [details] [review] [review]: Thanks for the review. > > • ABOUT-NLS and po/org.gnome.bijiben.pot shouldn’t be in version control. It's mentioned in the porting guide[0] that this pot file should be committed to the version control system. And see this example[1] of gtksourceview project, pot file is also in the version control system. *[0] https://wiki.gnome.org/MigratingFromIntltoolToGettext *[1] https://git.gnome.org/browse/gtksourceview/tree/data/styles
Unfortunately, the porting guide is outdated.
(In reply to Piotr Drąg from comment #17) > Unfortunately, the porting guide is outdated. Just one question, do we even need that .pot file?
We don’t need this whole thing with ITS Tool. Instead, you should use gettext’s ITS support: https://www.gnu.org/software/gettext/manual/html_node/Preparing-ITS-Rules.html For example, gnome-backgrounds uses it: https://git.gnome.org/browse/gnome-backgrounds/commit/?id=b22be04b6fe386ca97aea54ee2d9060e69437653
(In reply to Isaque Galdino from comment #15) > Review of attachment 358915 [details] [review] [review]: > > work-around pushed to master. Thank you! Any timeframe for a 3.24.2 with the fix?
(In reply to Piotr Drąg from comment #19) > We don’t need this whole thing with ITS Tool. Instead, you should use > gettext’s ITS support: > > https://www.gnu.org/software/gettext/manual/html_node/Preparing-ITS-Rules. > html > > For example, gnome-backgrounds uses it: > > https://git.gnome.org/browse/gnome-backgrounds/commit/ > ?id=b22be04b6fe386ca97aea54ee2d9060e69437653 Great. Thanks.
Created attachment 359503 [details] [review] Migrate from intltool to gettext Updated patch.
Comment on attachment 359503 [details] [review] Migrate from intltool to gettext As the translation issue has been fixed with the work-around patch. Mark this as obsolete. I'll file another bug for the patch migrating from intltool to gettext.
(In reply to Piotr Drąg from comment #20) > (In reply to Isaque Galdino from comment #15) > > Review of attachment 358915 [details] [review] [review] [review]: > > > > work-around pushed to master. > > Thank you! Any timeframe for a 3.24.2 with the fix? Hi Piotr, our idea is to deploy as 3.26, so we can catch up with GNOME release dates.
(In reply to Isaque Galdino from comment #24) > Hi Piotr, our idea is to deploy as 3.26, so we can catch up with GNOME > release dates. That will make non-English-speaking users on stable distributions stuck with unusable Bijiben. The best course of action would be to release 3.24.2 from gnome-3-24 and 3.26.0 from master simultaneously (or just the former as soon as possible).
(In reply to Piotr Drąg from comment #25) > unusable Bijiben. The best course of action would be to release 3.24.2 from > gnome-3-24 and 3.26.0 from master simultaneously (or just the former as soon > as possible). Hi Piotr, as we spoke in #bijiben channel, we agreed upon releasing it in 3.24.2, so I'll close this bug. Thanks.
I can confirmed that 3.24.2 has fixed translations. Thank you for everyone involved!