GNOME Bugzilla – Bug 786756
Standarize the option dialog switches
Last modified: 2021-06-09 16:29:11 UTC
Created attachment 358336 [details] screen-reader-dialog-screenshot The common pattern for the single option dialogs is to embed the label and switches in a GtkListBox (see Privacy -> Location Services).
Created attachment 358337 [details] [review] universal-access: Place the Screen Reader dialog switch in a ListBox This pattern is used all over gnome-control-center in dialogs such as the Privacy -> Location Services.
Dialogs TODO: * Sound Keys * Visual Alerts * Repeat Keys (move the Switch from the headerbar into the content area) * Cursor Blinking (same as Repeat Keys dialog)
Review of attachment 358337 [details] [review]: One comment. ::: panels/universal-access/uap.ui @@ +1130,3 @@ </child> <child> + <object class="GtkListBox"> We don't actually need a GtkListBox. Can be just a regular container with the 'view' style class' applied.
Created attachment 367324 [details] [review] universal-access: Style the Screen Reader dialog switch This pattern is used all over gnome-control-center in dialogs such as the Privacy -> Location Services.
Comment on attachment 358337 [details] [review] universal-access: Place the Screen Reader dialog switch in a ListBox reworded the commit message.
Review of attachment 367324 [details] [review]: Looks pretty good to me, thanks!
Attachment 367324 [details] pushed as 13d08b4 - universal-access: Style the Screen Reader dialog switch
Reopening; there are a few dialog left to be updated.
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version, then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a new bug report at https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/ Thank you for your understanding and your help.