After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786709 - Use a clearer/nicer title line in the new-message notification
Use a clearer/nicer title line in the new-message notification
Status: RESOLVED FIXED
Product: polari
Classification: Applications
Component: general
unspecified
Other All
: Normal minor
: ---
Assigned To: Polari maintainers
Polari maintainers
Depends on:
Blocks:
 
 
Reported: 2017-08-23 22:43 UTC by Daniel Boles
Modified: 2017-10-19 10:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
telepathyClient: Clarify title of msg notification (1.23 KB, patch)
2017-08-25 11:45 UTC, Daniel Boles
committed Details | Review

Description Daniel Boles 2017-08-23 22:43:41 UTC
The GNotification for a new message from room #theroom, user someone looks like

    theroom someone

    [Here is the message preview]


While I guess not really ambiguous - unless rooms can have spaces in their names - The room and user name are just kind of stuck together, and it looks a bit strange and clumsy. Wouldn't it be nicer if it looked like one of these?

    someone in theroom
    theroom: someone

or something else; it would just be nice to get some kind of punctuation between the room and user names, IMHO.

(I would suggest having a # to make it even clearer which one is the room name, but we don't seem to use that anywhere else in room names.)
Comment 1 Florian Müllner 2017-08-24 08:11:53 UTC
Fine with me if Bastian agrees, although probably not worth a string freeze request.
Comment 2 Daniel Boles 2017-08-25 11:45:46 UTC
Created attachment 358391 [details] [review]
telepathyClient: Clarify title of msg notification

    If Dennis messaged you from #room, the title was:

        room Dennis

    It seems clearer and more grammatical to say

        Dennis in room

--

Obviously, if someone has a preferred/better format for this string, go for it.
Comment 3 Bastian Ilsø 2017-08-26 08:45:20 UTC
Review of attachment 358391 [details] [review]:

looks good to me.
Comment 4 Daniel Boles 2017-08-30 07:37:00 UTC
Thanks!

Another thing I wondered: can the notification about a user-to-user /msg include the network name?
Comment 5 Florian Müllner 2017-08-30 09:17:08 UTC
Sure, but those are handled by gnome-shell, so you'll need to file a bug there.
Comment 6 Daniel Boles 2017-08-30 09:23:32 UTC
Here we go: https://bugzilla.gnome.org/show_bug.cgi?id=787009
Comment 7 Florian Müllner 2017-10-19 10:31:45 UTC
Attachment 358391 [details] pushed as 1aaf1ee - telepathyClient: Clarify title of msg notification

We branched, so let's get this off the list