GNOME Bugzilla – Bug 786689
"Enter URL" has inconsistent "go back" UI
Last modified: 2018-01-11 10:59:56 UTC
Created attachment 358250 [details] Screenshot of the "Enter URL" page (with the bug) The New -> Enter URL page is inconsistent with all the other pages in the WizardWindow when it comes to the behaviour of the "go back" UI. Others use the "back" button in the WizardToolbar headerbar. However, this one uses a strange looking (rounded lower left and right corners) GtkButton in the content area that says "< Enter URL", and the "back" button in the header bar is disabled. While there are bigger issues with this page (eg., bug 776955), this is relatively easier to fix.
Also, the alt+<left> keyboard shortcut doesn't work.
Created attachment 358251 [details] [review] wizard, wizard-source: Use the headerbar to go back from "Enter URL"
Created attachment 358252 [details] [review] wizard-source: Use 'requires' instead of 'assert'
Created attachment 358253 [details] Screenshot of the "Enter URL" page (with the patches)
Review of attachment 358251 [details] [review]: I found a problem. Clicking "back" once the download in progress skips back two steps to the main screen instead of presenting "enter URL" again.
Created attachment 358326 [details] [review] wizard, wizard-source: Use the headerbar to go back from "Enter URL" This makes things simpler by handling the back button in one place instead of having it spread across the Wizard and WizardSource. Otherwise the page changes done by one handler confuses the other.
Created attachment 358327 [details] [review] wizard-source: Use 'requires' instead of 'assert'
Created attachment 359278 [details] [review] wizard, wizard-source: Use the headerbar to go back from "Enter URL" Another level of simplification by updating the sensitivity of the back button only in Wizard.
Created attachment 359279 [details] [review] wizard-source: Use 'requires' instead of 'assert'
For the sake of leaving a paper trail: I learnt from Felipe that Jimmac prefers the existing UI.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-boxes/issues/165.