After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786664 - window: don't be aggressive in saving geometry
window: don't be aggressive in saving geometry
Status: RESOLVED FIXED
Product: bijiben
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Bijiben maintainer(s)
Bijiben maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-08-23 04:20 UTC by Mohammed Sadiq
Modified: 2017-08-28 03:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
window: don't be aggressive in saving geometry (4.71 KB, patch)
2017-08-23 04:20 UTC, Mohammed Sadiq
committed Details | Review

Description Mohammed Sadiq 2017-08-23 04:20:07 UTC
.
Comment 1 Mohammed Sadiq 2017-08-23 04:20:14 UTC
Created attachment 358198 [details] [review]
window: don't be aggressive in saving geometry

window geometry was been saved to gsettings for every minor change.
This was causing too much I/O.

So, save the geometry only after the change is complete (100 ms  is
taken as the threshold for this).

Also, since configure-event signal is emitted on window maximized/minimize
events, avoid using window-state-event handlers.
Comment 2 Isaque Galdino 2017-08-28 03:05:05 UTC
Review of attachment 358198 [details] [review]:

Pushed to master. Thanks for your patch.