After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786619 - egl: Don't require eglGetPlatformDisplayEXT, let it fail if not present
egl: Don't require eglGetPlatformDisplayEXT, let it fail if not present
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2017-08-22 15:44 UTC by Mario Sánchez Prada
Modified: 2017-08-22 16:36 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
egl: Don't require eglGetPlatformDisplayEXT, let it fail if not present (1.45 KB, patch)
2017-08-22 15:49 UTC, Mario Sánchez Prada
accepted-commit_now Details | Review

Description Mario Sánchez Prada 2017-08-22 15:44:58 UTC
When building mutter 3.24 and trying to run it on Endless (which uses X11), I found the following runtime error that prevented the shell from running:

  Window manager error: Failed to get proc address for 'eglGetPlatformDisplayEXT'

While debugging, I found the error was happening due to GET_EGL_PROC_ADDR_REQUIRED (eglGetPlatformDisplayEXT) [1], which is called while initializing the backend. Talking to Jonas on IRC he mentioned that this should only be required on Wayland, so we probably can simply remove the _REQUIRED part (and the unused macro) and let the call to eglGetPlatformDisplay() error accordingly.

[1] https://github.com/GNOME/mutter/blob/master/src/backends/meta-egl.c#L777
Comment 1 Mario Sánchez Prada 2017-08-22 15:49:38 UTC
Created attachment 358167 [details] [review]
egl: Don't require eglGetPlatformDisplayEXT, let it fail if not present
Comment 2 Jonas Ådahl 2017-08-22 16:03:18 UTC
Review of attachment 358167 [details] [review]:

lgtm. the commit message subject could loose everything after the comma; as we now do *not* fail if not present. The commit message body sufficiently describes the expected result however.
Comment 3 Mario Sánchez Prada 2017-08-22 16:36:44 UTC
Thanks Jonas. Fixed in master now with the amended commit message:
https://git.gnome.org/browse/mutter/commit/?id=e07524280199f3befee4f28729daf64b65b119e6