GNOME Bugzilla – Bug 786613
Adwaita: provide a generic sidebar icon and label styling
Last modified: 2017-09-05 11:56:33 UTC
We currently define placessidebar styling for icon and label. Apart from metrics, it also makes the icon semi-opaque to compensate for different weight compared to the text label. However we have a similar icon + label sidebars in places other than the file chooser. Nautilus uses such a sidebar bar and the new system settings shell does too. It would be nice to simply use a .sidebar-label and .sidebar-icon classes rather than having a narrow scope.
Created attachment 358152 [details] [review] Adwaita: make sidebar styling generic - allow consumers like system settings shell use the same styling
Not a great fan of that approach, I see possible abuses all over the place. Won't be better to have a generic sidebar row styling, hence the container of the label and the icon?
Created attachment 358270 [details] [review] adwaita: use generic sidebar icon style
lgtm, BUT add a comment related to this bug in the scss and in the commit message pls, that is pretty much nonsensical otherwise and I may just kill that :-)
Created attachment 358277 [details] [review] adwaita: use generic sidebar icon style
looks good, push it and close
Most of the changes to the .css files look, um, unncecessary...
indeed, it's just the sass interpreter though I guess, Jakub, how did you generate the css? Have you got sassc installed?
My bad. Used the ruby parser. Will regenerate using sassc.
Created attachment 358348 [details] [review] adwaita: use generic sidebar icon style
Review of attachment 358348 [details] [review]: please push this
Attachment 358348 [details] pushed as 417d345 - adwaita: use generic sidebar icon style