After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786611 - Standardise settings UI to match the rest of gnome-control-center
Standardise settings UI to match the rest of gnome-control-center
Status: RESOLVED FIXED
Product: gnome-bluetooth
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-bluetooth-general-maint@gnome.bugs
gnome-bluetooth-general-maint@gnome.bugs
: 786084 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2017-08-22 13:29 UTC by Allan Day
Modified: 2017-08-23 15:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch - use standard settings layout (3.83 KB, patch)
2017-08-22 13:41 UTC, Allan Day
none Details | Review
lib: Update UI for updated gnome-control-center UI (3.81 KB, patch)
2017-08-23 10:25 UTC, Bastien Nocera
committed Details | Review
settings: Align the explanatory text with the listbox (2.72 KB, patch)
2017-08-23 13:45 UTC, Bastien Nocera
committed Details | Review
lib: Make settings test window resizable (1016 bytes, patch)
2017-08-23 13:45 UTC, Bastien Nocera
committed Details | Review

Description Allan Day 2017-08-22 13:29:50 UTC
In bug 786384 we're trying to make the different settings panel look consistent, which is important for the new settings shell that has been enabled for 3.26.

The bluetooth panel would benefit from the same changes: consistent vertical spacing between sections and below headings and row heights that match those in the other panels.

Patch to follow.
Comment 1 Allan Day 2017-08-22 13:41:12 UTC
Created attachment 358148 [details] [review]
patch - use standard settings layout

This tweaks the layout to match the other settings panels.

One thing it doesn't do, which would be good, is to move the explanation label inside the box that contains the devices heading and list, so that it is aligned with "Devices" and has the same width as the list.
Comment 2 Bastien Nocera 2017-08-23 10:25:14 UTC
(In reply to Allan Day from comment #0)
> The bluetooth panel would benefit from the same changes: consistent vertical
> spacing between sections and below headings

I don't understand what needs to be consistent with what.

> and row heights that match those
> in the other panels.

What would that height be in pixels?
Comment 3 Bastien Nocera 2017-08-23 10:25:48 UTC
Created attachment 358223 [details] [review]
lib: Update UI for updated gnome-control-center UI

gnome-control-center panels are being given standardized layouts,
in order to provide a more seamless experience. This applies the
same layout rules to the Bluetooth Settings.

Apply a standard vertical spacing of 32px above and below
content and 12px below headings. Also aim for a standard row
height of 58px with the normal text size.
Comment 4 Allan Day 2017-08-23 10:35:20 UTC
(In reply to Bastien Nocera from comment #2)
> (In reply to Allan Day from comment #0)
> > The bluetooth panel would benefit from the same changes: consistent vertical
> > spacing between sections and below headings
> 
> I don't understand what needs to be consistent with what.

Most of the panels now have 32px vertical space between the top of the panel and controls/labels. This includes Wi-Fi, Notifications, Search, Region & Language, Universal Access, Privacy, Sharing, Power, Network. The idea of the patch is to do the same thing for Bluetooth.

Likewise we are using 12px space below headings with no indentation to the right. This can be seen in Wi-Fi, Notifications, Universal Access, Online Accounts, etc.

> > and row heights that match those
> > in the other panels.
> 
> What would that height be in pixels?

Where possible we are aiming for 58px tall, including borders. There are necessary exceptions, but the panels that use this row height include Region & Language, Universal Access, Privacy, Sharing, Power and Network.
Comment 5 Bastien Nocera 2017-08-23 13:45:42 UTC
Created attachment 358238 [details] [review]
settings: Align the explanatory text with the listbox

The text was a couple of pixels (4 to be exact) more inside the page
than the listbox. Make the margin apply to the box containing both the
listbox and the explanatory text so that there's no minute discrepancy
in alignment.
Comment 6 Bastien Nocera 2017-08-23 13:45:47 UTC
Created attachment 358239 [details] [review]
lib: Make settings test window resizable

As the Settings shell is resizable now.
Comment 7 Bastien Nocera 2017-08-23 14:23:20 UTC
Attachment 358223 [details] pushed as 04ea1b1 - lib: Update UI for updated gnome-control-center UI
Attachment 358238 [details] pushed as 78af0b0 - settings: Align the explanatory text with the listbox
Attachment 358239 [details] pushed as 98e2a7e - lib: Make settings test window resizable
Comment 8 Bastien Nocera 2017-08-23 15:03:36 UTC
*** Bug 786084 has been marked as a duplicate of this bug. ***