GNOME Bugzilla – Bug 786611
Standardise settings UI to match the rest of gnome-control-center
Last modified: 2017-08-23 15:03:36 UTC
In bug 786384 we're trying to make the different settings panel look consistent, which is important for the new settings shell that has been enabled for 3.26. The bluetooth panel would benefit from the same changes: consistent vertical spacing between sections and below headings and row heights that match those in the other panels. Patch to follow.
Created attachment 358148 [details] [review] patch - use standard settings layout This tweaks the layout to match the other settings panels. One thing it doesn't do, which would be good, is to move the explanation label inside the box that contains the devices heading and list, so that it is aligned with "Devices" and has the same width as the list.
(In reply to Allan Day from comment #0) > The bluetooth panel would benefit from the same changes: consistent vertical > spacing between sections and below headings I don't understand what needs to be consistent with what. > and row heights that match those > in the other panels. What would that height be in pixels?
Created attachment 358223 [details] [review] lib: Update UI for updated gnome-control-center UI gnome-control-center panels are being given standardized layouts, in order to provide a more seamless experience. This applies the same layout rules to the Bluetooth Settings. Apply a standard vertical spacing of 32px above and below content and 12px below headings. Also aim for a standard row height of 58px with the normal text size.
(In reply to Bastien Nocera from comment #2) > (In reply to Allan Day from comment #0) > > The bluetooth panel would benefit from the same changes: consistent vertical > > spacing between sections and below headings > > I don't understand what needs to be consistent with what. Most of the panels now have 32px vertical space between the top of the panel and controls/labels. This includes Wi-Fi, Notifications, Search, Region & Language, Universal Access, Privacy, Sharing, Power, Network. The idea of the patch is to do the same thing for Bluetooth. Likewise we are using 12px space below headings with no indentation to the right. This can be seen in Wi-Fi, Notifications, Universal Access, Online Accounts, etc. > > and row heights that match those > > in the other panels. > > What would that height be in pixels? Where possible we are aiming for 58px tall, including borders. There are necessary exceptions, but the panels that use this row height include Region & Language, Universal Access, Privacy, Sharing, Power and Network.
Created attachment 358238 [details] [review] settings: Align the explanatory text with the listbox The text was a couple of pixels (4 to be exact) more inside the page than the listbox. Make the margin apply to the box containing both the listbox and the explanatory text so that there's no minute discrepancy in alignment.
Created attachment 358239 [details] [review] lib: Make settings test window resizable As the Settings shell is resizable now.
Attachment 358223 [details] pushed as 04ea1b1 - lib: Update UI for updated gnome-control-center UI Attachment 358238 [details] pushed as 78af0b0 - settings: Align the explanatory text with the listbox Attachment 358239 [details] pushed as 98e2a7e - lib: Make settings test window resizable
*** Bug 786084 has been marked as a duplicate of this bug. ***