After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786610 - Review: Browser hangs with files with a few thousand lines
Review: Browser hangs with files with a few thousand lines
Status: RESOLVED FIXED
Product: website
Classification: Infrastructure
Component: extensions.gnome.org
current
Other Linux
: Normal major
: ---
Assigned To: Yuri Konotopov
Shell extensions maintainer(s)
https://git.gnome.org/browse/extensio...
Depends on:
Blocks:
 
 
Reported: 2017-08-22 13:17 UTC by Mario Wenzel
Modified: 2017-08-25 21:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
stuff breaking (97.73 KB, image/png)
2017-08-22 13:17 UTC, Mario Wenzel 		Details

Description Mario Wenzel 2017-08-22 13:17:15 UTC 
Created attachment 358146 [details]
stuff breaking

We have a few extensions that are quite complex with some files going up to a few thousand lines of code. Trying to review those, the UI in the browser hangs when switching to that specific diff.

It's basically impossible to do any reviews when some of them take upwards of half an hour to wait for a page to finish rendering.

And the queue just doesn't get smaller :(
Comment 1 Yuri Konotopov 2017-08-22 13:56:24 UTC 
What browser do you using?
Time++ review open quite fast with latest Chromium. However this is for sure browser and CPU/mem dependent.
Comment 2 Yuri Konotopov 2017-08-22 13:58:39 UTC 
Ah, I see that todo.js is big enough to hang UI.
I will work around this issue soon.
Comment 3 Yuri Konotopov 2017-08-25 21:58:40 UTC 
I rewritten most slowest parts of diff.js in commit c05512af20, so it should be much faster now.

todo.js diff (in reported review) now opens within 1.15 sec at my PC.

If you find some slow diffs please report them.