After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786605 - Devices and Details shouldn't have the same icons
Devices and Details shouldn't have the same icons
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: shell
3.25.x
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
: 785872 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2017-08-22 12:48 UTC by Bastien Nocera
Modified: 2017-08-23 16:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch - use mouse and dialog-information icons for devices and details (1.56 KB, patch)
2017-08-23 10:41 UTC, Allan Day
none Details | Review
symbolic: new symbolics for new settings shell (25.41 KB, patch)
2017-08-23 14:07 UTC, Jakub Steiner
none Details | Review
patch - use new icons for devices and details (1.75 KB, patch)
2017-08-23 16:00 UTC, Allan Day
committed Details | Review

Description Bastien Nocera 2017-08-22 12:48:37 UTC
The gear icon is used for both a panel, and a sub-section.
Comment 1 Allan Day 2017-08-22 15:50:34 UTC
Yep, this is an obvious issue. I'm not a fan of using the gear in either case, actually - it is generally read as "settings" so doesn't mean a huge amount.

The best I can come up with is to use input-mouse-symbolic for devices and dialog-information-symbolic for details.

The mouse icon is potentially misleading, since devices includes both internal hardware as well as peripherals. However, nothing better occurs to me.
Comment 2 Allan Day 2017-08-22 15:52:15 UTC
*** Bug 785872 has been marked as a duplicate of this bug. ***
Comment 3 Allan Day 2017-08-23 10:41:48 UTC
Created attachment 358224 [details] [review]
patch - use mouse and dialog-information icons for devices and details

Simple patch to change the icons.
Comment 4 Bastien Nocera 2017-08-23 10:53:46 UTC
(In reply to Allan Day from comment #3)
> Created attachment 358224 [details] [review] [review]
> patch - use mouse and dialog-information icons for devices and details

It's a shame that the mouse icon is now duplicated. Would a variation of "audio-card-symbolic" without the note be better/worse?

As for dialog-information, it would be nicer if it was copied in the icon theme so that this patch would reference "settings-details" or something like that, rather than reusing an icon that was present for another purpose.
Comment 5 Bastien Nocera 2017-08-23 10:57:00 UTC
Review of attachment 358224 [details] [review]:

> Subject: [PATCH] panel list: use appropriate icons for devices and details

"git log" on the file will show that the usual prefix for it is "panel-list: "

A little explanation in the commit message as to why each icon was chosen would also be helpful.
Comment 6 Jakub Steiner 2017-08-23 14:07:23 UTC
Created attachment 358241 [details] [review]
symbolic: new symbolics for new settings shell
Comment 7 Allan Day 2017-08-23 16:00:46 UTC
Created attachment 358247 [details] [review]
patch - use new icons for devices and details

Here's an updated patch which uses the icons that have now been committed to adwaita-icon-theme. It hopefully has a better commit message.
Comment 8 Rui Matos 2017-08-23 16:38:18 UTC
Review of attachment 358247 [details] [review]:

lgtm, thanks