GNOME Bugzilla – Bug 786605
Devices and Details shouldn't have the same icons
Last modified: 2017-08-23 16:39:42 UTC
The gear icon is used for both a panel, and a sub-section.
Yep, this is an obvious issue. I'm not a fan of using the gear in either case, actually - it is generally read as "settings" so doesn't mean a huge amount. The best I can come up with is to use input-mouse-symbolic for devices and dialog-information-symbolic for details. The mouse icon is potentially misleading, since devices includes both internal hardware as well as peripherals. However, nothing better occurs to me.
*** Bug 785872 has been marked as a duplicate of this bug. ***
Created attachment 358224 [details] [review] patch - use mouse and dialog-information icons for devices and details Simple patch to change the icons.
(In reply to Allan Day from comment #3) > Created attachment 358224 [details] [review] [review] > patch - use mouse and dialog-information icons for devices and details It's a shame that the mouse icon is now duplicated. Would a variation of "audio-card-symbolic" without the note be better/worse? As for dialog-information, it would be nicer if it was copied in the icon theme so that this patch would reference "settings-details" or something like that, rather than reusing an icon that was present for another purpose.
Review of attachment 358224 [details] [review]: > Subject: [PATCH] panel list: use appropriate icons for devices and details "git log" on the file will show that the usual prefix for it is "panel-list: " A little explanation in the commit message as to why each icon was chosen would also be helpful.
Created attachment 358241 [details] [review] symbolic: new symbolics for new settings shell
Created attachment 358247 [details] [review] patch - use new icons for devices and details Here's an updated patch which uses the icons that have now been committed to adwaita-icon-theme. It hopefully has a better commit message.
Review of attachment 358247 [details] [review]: lgtm, thanks