After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786454 - wrong player.set_playlist call in albumwidget.py
wrong player.set_playlist call in albumwidget.py
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-music-maint
gnome-music-maint
Depends on:
Blocks:
 
 
Reported: 2017-08-18 08:52 UTC by Jean Felder
Modified: 2017-08-28 12:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix (565 bytes, patch)
2017-08-18 08:52 UTC, Jean Felder 		committed Details | Review

Description Jean Felder 2017-08-18 08:52:18 UTC 
Created attachment 357866 [details] [review]
fix

self._player.set_playlist is called with 'Artist' parameter while it should be 'Album'.
See patch attached.
Comment 1 Marinus Schraal 2017-08-28 12:43:29 UTC 
How you even spotted this is beyond me, but thanks for the patch.

Goes to show how irrelevant some of these arguments are that clearly 
wrong input doesn't do anything noticable. There's a lot of work left in 
player.py.

As far as the commit goes, pay attention to the commit msg (1) and try 
to use git-bz for filing patches/bugs (2).

1. https://wiki.gnome.org/Git/CommitMessages
2. https://wiki.gnome.org/Git/WorkingWithPatches