After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786440 - [PATCH] Remove calls to deprecated functions gdk_threads_{enter,leave}
[PATCH] Remove calls to deprecated functions gdk_threads_{enter,leave}
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-08-17 18:52 UTC by Jonas Hahnfeld
Modified: 2017-08-19 06:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Remove calls to deprecated functions gdk_threads_{enter,leave} (1.10 KB, patch)
2017-08-17 18:52 UTC, Jonas Hahnfeld
committed Details | Review

Description Jonas Hahnfeld 2017-08-17 18:52:41 UTC
Created attachment 357830 [details] [review]
Remove calls to deprecated functions  gdk_threads_{enter,leave}

These weren't needed anyway:
  * ev_timeline_run_frame is referenced from two calls to g_timeout_add.
    The callbacks will be emitted in the main thread.
  * The function does neither call any GTK+ nor GDK function.

"Tested" with an example presentation using transitions. Please check that I got that right!
Comment 1 Carlos Garcia Campos 2017-08-19 06:44:03 UTC
Comment on attachment 357830 [details] [review]
Remove calls to deprecated functions  gdk_threads_{enter,leave}

Agree, thanks you