After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786435 - Don't encode timezone in generated files
Don't encode timezone in generated files
Product: msitools
Classification: Other
Component: gcab
Other Linux
: Normal normal
: 1.0
Assigned To: msitools maintainer(s)
msitools maintainer(s)
Depends on:
Reported: 2017-08-17 16:51 UTC by Chris Lamb
Modified: 2017-08-20 21:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

patch (1.05 KB, patch)
2017-08-17 16:51 UTC, Chris Lamb
none Details | Review

Description Chris Lamb 2017-08-17 16:51:05 UTC
Created attachment 357824 [details] [review]

Whilst working on the Reproducible Builds effort [0], we noticed
that gcab generates .cab files that are not reproducible. This
affects packages such as fwupd.

This is because the embedded dates are encoded with the current

Comment 1 Marc-Andre Lureau 2017-08-18 12:09:32 UTC
Review of attachment 357824 [details] [review]:

why is gmtime better than localtime?
Comment 2 Chris Lamb 2017-08-18 14:02:52 UTC
localtime is expressed relative to the user's specified timezone, whilst gmtime is in UTC. This is important so that users building the exact same contents in different timezones will end up with the same exact .cab file.