After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786415 - libdocument: Use a byte rather than an unsigned int for memset
libdocument: Use a byte rather than an unsigned int for memset
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-08-17 10:57 UTC by Tobias Mueller
Modified: 2017-08-19 06:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
libdocument: Use a byte rather than an unsigned int for memset (1.18 KB, patch)
2017-08-17 10:57 UTC, Tobias Mueller 		committed Details | Review

Description Tobias Mueller 2017-08-17 10:57:45 UTC 
The patch should apply cleanly after the patches in bug 786414.
The patch is not otherwise related to bug 786414, so I felt
a separate bug report is more appropriate.
Comment 1 Tobias Mueller 2017-08-17 10:57:49 UTC 
Created attachment 357797 [details] [review]
libdocument: Use a byte rather than an unsigned int for memset

Currently, gcc emits a warning for the constant used in the memset call.
memset really sets a byte, so let's use one here, instead of the bigger
unsigned integer.

ev-document-misc.c:77:40: warning: conversion of unsigned constant value
to negative integer [-Wsign-conversion]
    memset (data + (rowstride * i) + 4, 0xffffffff, nbytes);
Comment 2 Carlos Garcia Campos 2017-08-19 06:54:21 UTC 
Comment on attachment 357797 [details] [review]
libdocument: Use a byte rather than an unsigned int for memset

Pushed, thanks!