After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786364 - Not all C source files are UTF-8
Not all C source files are UTF-8
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: dont know
git master
Other Linux
: Normal normal
: 1.12.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-08-16 12:01 UTC by Jan Alexander Steffens (heftig)
Modified: 2017-08-16 12:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[PATCH] goom2k1: Convert source files to UTF-8 (4.57 KB, patch)
2017-08-16 12:02 UTC, Jan Alexander Steffens (heftig)
committed Details | Review
[PATCH] sys: Convert source files to UTF-8 (3.25 KB, patch)
2017-08-16 12:03 UTC, Jan Alexander Steffens (heftig)
committed Details | Review

Description Jan Alexander Steffens (heftig) 2017-08-16 12:01:53 UTC
Some source files contain non-UTF-8 comments. gtk-doc 1.26, if build with Python 3, chokes on such files.
Comment 1 Jan Alexander Steffens (heftig) 2017-08-16 12:02:35 UTC
Created attachment 357716 [details] [review]
[PATCH] goom2k1: Convert source files to UTF-8

This one is for gst-plugins-good.
Comment 2 Jan Alexander Steffens (heftig) 2017-08-16 12:03:22 UTC
Created attachment 357717 [details] [review]
[PATCH] sys: Convert source files to UTF-8

This one is for gst-plugins-bad.
Comment 3 Tim-Philipp Müller 2017-08-16 12:11:48 UTC
commit 1de2df03be7a1d87ca79f90269ddc5264c6e4293
Author: Jan Alexander Steffens (heftig) <jan.steffens@gmail.com>
Date:   Wed Aug 16 13:57:50 2017 +0200

    goom2k1: Convert source files to UTF-8
    
    Causes problems with the new gtk-doc 1.26 otherwise,
    but is a good idea in any case.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=786364

commit f338621446a6360611166561172abe10ef46e568
Author: Jan Alexander Steffens (heftig) <jsteffens@make.tv>
Date:   Wed Aug 16 13:59:01 2017 +0200

    sys: Convert source files to UTF-8
    
    Otherwise we have problems with the new gtk-doc
    ported to python. But it's a good thing to do
    anyway.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=786364