GNOME Bugzilla – Bug 786358
Please add a flag to disable seccomp support
Last modified: 2018-02-06 13:32:15 UTC
Hi, ATM, gnome-desktop will try to build with seccomp support on linux architectures but seccomp is not compatible with some of them (m68k, alpha, sparc64,...) that are built on debian. Adding a configure flag would help here so we would be able to disable seccomp support on these architectures https://buildd.debian.org/status/package.php?p=libseccomp
It really doesn't look clear to me whether libseccomp is unavailable at all on those systems, or is ineffective and attempting to use it will fail. Looking at the build logs also didn't tell me much about this, other than some build failures with errors that might or might not be packaging problems. Can you please check with the libseccomp maintainers whether those platforms will be able to compile libseccomp in the future?
It definitely looks like the supported architectures is limited: https://github.com/seccomp/libseccomp/blob/master/src/arch.c#L120 libseccomp build fails with: arch.c:100:2: error: #error the arch code needs to know about your machine type
I'd take a patch to explicitly disable seccomp on those architectures (as on non-Linux), not as an option though. Also make sure to add a AC_MSG_WARN() call to mention that seccomp support is disabled on that system.
Created attachment 367911 [details] [review] Disable seccomp on linux architectures where it's not supported
Review of attachment 367911 [details] [review]: > Disable seccomp on linux architectures where it's not supported Missing prefix "build: " in the commit subject. Please also link to a reference that shows those architectures not being support. Was this tested?
Created attachment 367915 [details] [review] build: Disable seccomp on linux architectures where it's not supported seccomp is currently not supported on all the linux architectures, see: https://github.com/seccomp/libseccomp/blob/master/src/arch.c Only disable seccomp on architectures where it's not supported, keep it enabled on all the other (linux) ones.
Review of attachment 367915 [details] [review]: Looks good otherwise, but again, was this tested? ::: configure.ac @@ +173,3 @@ + ;; + alpha|ia64|m68k|sh4|sparc64) + enable_seccomp="no (not avaiable on this architecture)" available
Comment on attachment 367915 [details] [review] build: Disable seccomp on linux architectures where it's not supported Well yes tested and it actually failed to build on the debian build daemons. The default (*) condition should actually be the last, I'll update the patch tomorrow
Created attachment 367953 [details] [review] build: Disable seccomp on linux architectures where it's not supported seccomp is currently not supported on all the linux architectures, see: https://github.com/seccomp/libseccomp/blob/master/src/arch.c Only disable seccomp on architectures where it's not supported, keep it enabled on all the other (linux) ones.
OK so that last version seems to work: https://buildd.debian.org/status/package.php?p=gnome-desktop3&suite=sid
Pushed with some minor commit message changes, thanks