After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786342 - TIFF loader is not being built
TIFF loader is not being built
Status: RESOLVED FIXED
Product: gdk-pixbuf
Classification: Platform
Component: loaders
git master
Other Linux
: Normal normal
: ---
Assigned To: gdk-pixbuf-maint
gdk-pixbuf-maint
: 786383 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2017-08-15 22:35 UTC by dkoukola
Modified: 2017-11-30 01:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
build: Fix TIFF loader compilation with autotools (2.25 KB, patch)
2017-09-11 17:12 UTC, Bastien Nocera
committed Details | Review

Description dkoukola 2017-08-15 22:35:56 UTC
The TIFF loader is no longer being built even though the libtiff library is detected.

I think the problem is in the following commit:

https://git.gnome.org/browse/gdk-pixbuf/commit/?id=0927eb3e278e998248f3022c096b4f93685c6a9d

PKG_CHECK_MODULES macro sets TIFF_LIBS variable instead of the formerly used LIBTIFF, but other parts of the build system files still expect LIBTIFF, eg.:

AM_CONDITIONAL(HAVE_TIFF, test "x$LIBTIFF" != x)

libpixbufloader_tiff_la_LIBADD = $(LIBTIFF) $(module_libs)
Comment 1 Emmanuele Bassi (:ebassi) 2017-08-16 17:32:59 UTC
*** Bug 786383 has been marked as a duplicate of this bug. ***
Comment 2 Phillip Berndt 2017-08-16 17:39:54 UTC
Since my bug was closed as a duplicate please note that in my case the effects are much more severe. I don't get a working build with missing tiff loader, but instead the build fails completely because it *does* compile the libtiff stuff but then forgets to link against it.
Comment 3 Phillip Berndt 2017-09-02 10:51:59 UTC
FYI, 2.38.9 is still affected:

[..]
  CC       gdk-pixbuf-csource.o
  CCLD     gdk-pixbuf-csource
./.libs/libgdk_pixbuf-2.0.so: undefined reference to `TIFFWriteScanline'
./.libs/libgdk_pixbuf-2.0.so: undefined reference to `TIFFClose'
./.libs/libgdk_pixbuf-2.0.so: undefined reference to `TIFFSetErrorHandler'
./.libs/libgdk_pixbuf-2.0.so: undefined reference to `TIFFGetField'
./.libs/libgdk_pixbuf-2.0.so: undefined reference to `TIFFIsCODECConfigured'
./.libs/libgdk_pixbuf-2.0.so: undefined reference to `TIFFClientOpen'
./.libs/libgdk_pixbuf-2.0.so: undefined reference to `TIFFSetField'
./.libs/libgdk_pixbuf-2.0.so: undefined reference to `TIFFReadDirectory'
./.libs/libgdk_pixbuf-2.0.so: undefined reference to `TIFFSetWarningHandler'
./.libs/libgdk_pixbuf-2.0.so: undefined reference to `TIFFReadRGBAImageOriented'
./.libs/libgdk_pixbuf-2.0.so: undefined reference to `TIFFFdOpen'
[..]
Makefile:1874: recipe for target 'gdk-pixbuf-csource' failed
Comment 4 Phillip Berndt 2017-09-02 10:52:43 UTC
2.36.9, of course. Sorry.
Comment 5 Bastien Nocera 2017-09-11 17:12:26 UTC
Created attachment 359549 [details] [review]
build: Fix TIFF loader compilation with autotools
Comment 6 Bastien Nocera 2017-09-11 17:17:20 UTC
Above is an untested patch. As a sidenote, both jhbuild and gnome-continuous use meson to build gdk-pixbuf, which is why this wouldn't have got caught.

Let me know whether that fixes the problem for you.
Comment 7 dkoukola 2017-09-11 22:28:25 UTC
(In reply to Bastien Nocera from comment #6)
> Above is an untested patch. As a sidenote, both jhbuild and gnome-continuous
> use meson to build gdk-pixbuf, which is why this wouldn't have got caught.
> 
> Let me know whether that fixes the problem for you.

The patch fixes the issue for me, thank you.
Comment 8 Bastien Nocera 2017-09-12 08:22:39 UTC
Attachment 359549 [details] pushed as 66537d1 - build: Fix TIFF loader compilation with autotools
Comment 9 hlein-gb 2017-09-19 00:12:28 UTC
Note that with this change, building without the tiff library installed no longer works, even if --without-libtiff is passed to configure.  The build attempts to compile io-tiff.c, and fails when tiffio.h is not found.

See https://bugs.gentoo.org/show_bug.cgi?id=631088 for more details.

Please let me know if this ought to be filed as a new bug instead.
Comment 10 Bastien Nocera 2017-09-19 09:39:01 UTC
Please file a new bug if this still happens with git master, thanks.
Comment 11 Bastien Nocera 2017-11-30 01:53:31 UTC
*** Bug 786383 has been marked as a duplicate of this bug. ***