After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786335 - No need to add a Soup.ProxyResolverDefault to a Soup.Session
No need to add a Soup.ProxyResolverDefault to a Soup.Session
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
3.22.x
Other All
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-08-15 17:38 UTC by Debarshi Ray
Modified: 2017-08-29 11:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
downloader: Remove redundant code (1.08 KB, patch)
2017-08-15 17:39 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2017-08-15 17:38:22 UTC 
We already use libsoup >= 2.44. Soup.Session.proxy-resolver is automatically set to the default GLib.ProxyResolver, which is the same thing as adding a Soup.ProxyResolverDefault.
Comment 1 Debarshi Ray 2017-08-15 17:39:12 UTC 
Created attachment 357660 [details] [review]
downloader: Remove redundant code
Comment 2 Felipe Borges 2017-08-29 11:04:45 UTC 
Review of attachment 357660 [details] [review]:

sure
Comment 3 Felipe Borges 2017-08-29 11:05:19 UTC 
Attachment 357660 [details] pushed as 2941cd8 - downloader: Remove redundant code