After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786325 - adaptivedemux: Add max-download-errors and min-fragment-download-retry-time properties
adaptivedemux: Add max-download-errors and min-fragment-download-retry-time p...
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-08-15 15:01 UTC by GstBlub
Modified: 2018-11-03 14:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
adaptivedemux: Add max-download-errors and min-fragment-download-retry-time properties (7.39 KB, patch)
2017-08-15 15:01 UTC, GstBlub 		needs-work Details | Review

Description GstBlub 2017-08-15 15:01:08 UTC 
Created attachment 357635 [details] [review]
adaptivedemux: Add max-download-errors and min-fragment-download-retry-time properties

This allows an application to customize error handling a bit more.
Comment 1 Edward Hervey 2017-08-28 07:00:39 UTC 
Review of attachment 357635 [details] [review]:

This patch looks wrong. It should only contain the changes for using the property instead of hardcoded values.
Comment 2 GstBlub 2017-08-28 21:57:42 UTC 
Well, the hardcoded values already don't make sense as they are because they won't work right.  For example, MAX_DOWNLOAD_ERROR_COUNT (which was hardcoded to 3) would never work on a live HLS stream because the retry timer was set to half a fragment's time, so at most the error count could have reached 2, rendering a live stream that pointed to invalid URLs to be silent indefinitely.  Making the values configurable without fixing the logic so that it actually works makes little sense.
Comment 3 GStreamer system administrator 2018-11-03 14:12:21 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/599.