After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786318 - Build: respect libexecdir options of meson
Build: respect libexecdir options of meson
Status: RESOLVED OBSOLETE
Product: gnome-multi-writer
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Multi Writer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-08-15 12:36 UTC by Dominique Leuenberger
Modified: 2017-12-06 16:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Build: respect libexecdir options of meson (624 bytes, patch)
2017-08-15 12:36 UTC, Dominique Leuenberger 		none Details | Review
build: Do not hardcode installation paths (4.84 KB, patch)
2017-08-15 12:55 UTC, Emmanuele Bassi (:ebassi) 		none Details | Review
build: Do not hardcode installation paths (4.93 KB, patch)
2017-08-15 14:32 UTC, Emmanuele Bassi (:ebassi) 		accepted-commit_now Details | Review

Description Dominique Leuenberger 2017-08-15 12:36:53 UTC 
meson install hardcoded /usr/libexec otherwise
Comment 1 Dominique Leuenberger 2017-08-15 12:36:58 UTC 
Created attachment 357624 [details] [review]
Build: respect libexecdir options of meson
Comment 2 Emmanuele Bassi (:ebassi) 2017-08-15 12:55:49 UTC 
Created attachment 357625 [details] [review]
build: Do not hardcode installation paths

Always use the configuration options from Meson.
Comment 3 Emmanuele Bassi (:ebassi) 2017-08-15 12:56:35 UTC 
I went through the whole thing and removed all hardcoded paths, as there were a ton more occurrences.
Comment 4 Richard Hughes 2017-08-15 13:26:00 UTC 
I'm not sure about the gmw prefix; what about something like prefixed_localedir instead? Then I can do the same fix to all my other project that do the same thing...
Comment 5 Emmanuele Bassi (:ebassi) 2017-08-15 14:32:26 UTC 
Created attachment 357631 [details] [review]
build: Do not hardcode installation paths

Always use the configuration options from Meson.
Comment 6 Richard Hughes 2017-08-15 15:02:47 UTC 
Review of attachment 357631 [details] [review]:

LGTM, thanks.
Comment 7 GNOME Infrastructure Team 2017-12-06 16:37:59 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-multi-writer/issues/4.