After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786311 - Ineffective "static workspaces" setting
Ineffective "static workspaces" setting
Status: RESOLVED FIXED
Product: gnome-tweak-tool
Classification: Applications
Component: general
3.25.x
Other Linux
: Normal critical
: ---
Assigned To: GNOME Tweak Tool maintainer(s)
GNOME Tweak Tool maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-08-15 10:46 UTC by Jimmy Scionti
Modified: 2017-09-20 16:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
The observed behaviour on Virtual Machine (239.89 KB, image/png)
2017-08-15 10:46 UTC, Jimmy Scionti
  Details
workspaces: Fix Workspaces tweaks (2.65 KB, patch)
2017-09-20 16:10 UTC, Jeremy Bicha
committed Details | Review

Description Jimmy Scionti 2017-08-15 10:46:44 UTC
Created attachment 357618 [details]
The observed behaviour on Virtual Machine

I flagged "Static Workspaces" in gnome-tweaks and set "1" as the total "Number of Workspaces".


Expected behaviour: only 1 workspace available + the workspace dock should be hidden in the overview.

Observed behaviour: the system is unaffected, it keeps showing the "dynamic workspace" behaviour.


GNOME Tweaks 3.25.90.1
GNOME Shell 3.24.3
GNOME Ubuntu 17.10
Comment 1 Florian Müllner 2017-08-15 12:43:49 UTC
This is a regression. The redesign dropped the handling of gnome-shell's override schemas, so the option now always controls the setting from the 'org.gnome.mutter' schema, while the *actual* schema used by gnome-shell is 'org.gnome.shell.overrides' (or 'org.gnome.shell.extensions.classic-overrides' in classic mode) ...
Comment 2 Jeremy Bicha 2017-09-05 07:24:41 UTC
(In reply to Florian Müllner from comment #1)
> This is a regression. The redesign dropped the handling of gnome-shell's
> override schemas, so the option now always controls the setting from the
> 'org.gnome.mutter' schema, while the *actual* schema used by gnome-shell is
> 'org.gnome.shell.overrides' (or
> 'org.gnome.shell.extensions.classic-overrides' in classic mode) ...

I did not drop anything like that since 3.24. And in my testing, it looks like the mutter gsettings schemas (and not the shell.overrides) are used for dynamic-workspaces in GNOME Shell 3.25.90.

Also, I cannot duplicate this bug with today's Ubuntu 17.10.

Jimmy, are you still affected by this issue?
Comment 3 Florian Müllner 2017-09-05 07:43:25 UTC
(In reply to Jeremy Bicha from comment #2)
> I did not drop anything like that since 3.24. 

Yes, in commit 624f44920826b3a187 to be exact - _GSettingsTweak has logic to automatically use the correct override schema where necessary, see adjust_schema_for_overrides() in widgets.py.


> And in my testing, it looks like the mutter gsettings schemas 
> (and not the shell.overrides) are used for dynamic-workspaces 
> in GNOME Shell 3.25.90.

I know that Ubuntu ships the patches from bug 746592, they may also have applied something similar to the patches in bug 786496 which indeed make the override mechanism obsolete. However none of that is upstream yet, so the setting is broken for non-patched glib/gnome-shell versions.
Comment 4 Jeremy Bicha 2017-09-05 07:58:01 UTC
Florian, thanks for the follow up. I can confirm the bug with Ubuntu 17.10's "GNOME" session but not with the "Ubuntu" session (which is a GNOME Shell mode).

(By the way, it does not look to me like Ubuntu includes patches from bug 786496.)
Comment 5 Jimmy Scionti 2017-09-05 13:12:26 UTC
(In reply to Jeremy Bicha from comment #2)
> Jimmy, are you still affected by this issue?

Yes, I still have the issue in gnome-ubuntu 17.10, even if gnome-shell version is now 3.25.91.
Comment 6 Jeremy Bicha 2017-09-20 16:10:52 UTC
Created attachment 360142 [details] [review]
workspaces: Fix Workspaces tweaks
Comment 7 Jeremy Bicha 2017-09-20 16:12:08 UTC
Attachment 360142 [details] pushed as a4e2437 - workspaces: Fix Workspaces tweaks