After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786310 - Bump the libsoup requirement to reflect reality
Bump the libsoup requirement to reflect reality
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
3.22.x
Other All
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-08-15 10:18 UTC by Debarshi Ray
Modified: 2017-08-23 11:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
configure: Require libsoup >= 2.44 (735 bytes, patch)
2017-08-15 10:24 UTC, Debarshi Ray
committed Details | Review

Description Debarshi Ray 2017-08-15 10:18:27 UTC
Since commit 6f955b5cad16537c, Boxes implicitly requires libsoup-2.44. SoupSession stopped being an abstract class in libsoup-2.42 [1, 2], while SoupKnownStatusCode was renamed in libsoup-2.44 [3, 4].

Let's update configure.ac to reflect this.

[1] https://developer.gnome.org/libsoup/stable/SoupSession.html#soup-session-new
[2] https://git.gnome.org/browse/libsoup/commit/?id=967dcc28f43cd47a75b7ff2c069807edb9929400
[3] https://developer.gnome.org/libsoup/stable/libsoup-2.4-soup-status.html#SoupStatus
[4] https://git.gnome.org/browse/libsoup/commit/?id=7f9c7c8731821149ff42971fad18e2a9abbb4c10
Comment 1 Debarshi Ray 2017-08-15 10:24:54 UTC
Created attachment 357617 [details] [review]
configure: Require libsoup >= 2.44
Comment 2 Felipe Borges 2017-08-23 11:56:39 UTC
Review of attachment 357617 [details] [review]:

Thanks!
Comment 3 Felipe Borges 2017-08-23 11:57:15 UTC
Attachment 357617 [details] pushed as 22449a5 - configure: Require libsoup >= 2.44