After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786300 - wayland/buffer: Add missing breaks in switch statement
wayland/buffer: Add missing breaks in switch statement
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: wayland
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2017-08-15 03:17 UTC by Jonas Ådahl
Modified: 2017-08-16 05:42 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
wayland/buffer: Add missing breaks in switch statement (1.25 KB, patch)
2017-08-15 03:17 UTC, Jonas Ådahl
committed Details | Review

Description Jonas Ådahl 2017-08-15 03:17:08 UTC
This came up as coverity issues.
Comment 1 Jonas Ådahl 2017-08-15 03:17:11 UTC
Created attachment 357603 [details] [review]
wayland/buffer: Add missing breaks in switch statement

We'd process damage, and no matter whether it succeeded or not we'd
pretend it succeeded, meaning any potential GError would be leaked.
Comment 2 Florian Müllner 2017-08-15 09:29:10 UTC
Review of attachment 357603 [details] [review]:

Good catch
Comment 3 Jonas Ådahl 2017-08-16 05:42:32 UTC
Attachment 357603 [details] pushed as 9a47e5c - wayland/buffer: Add missing breaks in switch statement