After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786287 - configure.ac: Missing quote for AC_MSG_ERROR in AS_IF for WAYLAND_SCANNER
configure.ac: Missing quote for AC_MSG_ERROR in AS_IF for WAYLAND_SCANNER
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
3.22.x
Other All
: Normal minor
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2017-08-14 17:59 UTC by Hannes Mueller
Modified: 2017-08-14 22:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1022 bytes, patch)
2017-08-14 17:59 UTC, Hannes Mueller 		committed Details | Review

Description Hannes Mueller 2017-08-14 17:59:09 UTC 
Created attachment 357567 [details] [review]
patch

Without quoting the comma in AC_MSG_ERROR wrongly separates if and else path. Attached a related patch to fix this issue.
Comment 1 Daniel Boles 2017-08-14 20:00:40 UTC 
Review of attachment 357567 [details] [review]:

Makes perfect sense and fixes the generated shell code.

Your patch is incomplete, though; I can't git am it because you didn't provide a committer email address.
Comment 2 Daniel Boles 2017-08-14 20:01:57 UTC 
(of course, I did edit the patch to make it work, using your bugzilla email address, so if you don't have commit access, I can just push that version)

btw, autotools is about to be dropped from GTK+ 4, so this will probably end up applying to GTK+ 3 only
Comment 3 Daniel Boles 2017-08-14 21:50:58 UTC 
(In reply to Daniel Boles from comment #2)
> btw, autotools is about to be dropped from GTK+ 4, so this will probably end
> up applying to GTK+ 3 only

and it is done!
Comment 4 Daniel Boles 2017-08-14 22:20:31 UTC 
Comment on attachment 357567 [details] [review]
patch

committed with fixes to the commit message, for line width, wording, and adding the bug URL.

Thanks for the patch!