After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786274 - "Recently used" not "Recently viewed"
"Recently used" not "Recently viewed"
Status: RESOLVED FIXED
Product: gnome-characters
Classification: Other
Component: general
3.24.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Characters maintainer(s)
GNOME Characters maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-08-14 11:27 UTC by Bastien Nocera
Modified: 2017-08-14 13:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
character: Add to Recent list when copied not viewed (2.39 KB, patch)
2017-08-14 11:45 UTC, Bastien Nocera 		none Details | Review
character: Add to Recent list when copied not viewed (2.23 KB, patch)
2017-08-14 12:52 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2017-08-14 11:27:44 UTC 
Browsing for characters should not add them to the "recently used" section unless they were copied.
Comment 1 Bastien Nocera 2017-08-14 11:45:04 UTC 
Created attachment 357547 [details] [review]
character: Add to Recent list when copied not viewed

Otherwise one would end up with loads of uninteresting characters
in the Recent view.
Comment 2 Daiki Ueno 2017-08-14 11:55:10 UTC 
Review of attachment 357547 [details] [review]:

Thank you for the quick patch, I only have a minor suggestion here.

::: src/window.js
@@ +358,3 @@
             transient_for: this.get_toplevel(),
+            fontDescription: this.visible_child.getFontDescription(),
+            mainView: this

Instead of passing around "this", I would suggest to add a new signal, say CharacterDialog::character-copied, and connect to it in this function.
Comment 3 Bastien Nocera 2017-08-14 12:52:59 UTC 
Created attachment 357550 [details] [review]
character: Add to Recent list when copied not viewed

Otherwise one would end up with loads of uninteresting characters
in the Recent view.
Comment 4 Daiki Ueno 2017-08-14 12:57:16 UTC 
Review of attachment 357550 [details] [review]:

Thank you.
Comment 5 Bastien Nocera 2017-08-14 13:40:00 UTC 
Attachment 357550 [details] pushed as 652d62c - character: Add to Recent list when copied not viewed