After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786258 - build: 3.25.90.1 doesn't detect lirc library
build: 3.25.90.1 doesn't detect lirc library
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: general
3.25.x
Other All
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-08-13 23:19 UTC by Jeremy Bicha
Modified: 2017-08-14 08:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: Fix lirc library detection (939 bytes, patch)
2017-08-13 23:19 UTC, Jeremy Bicha 		none Details | Review
lirc: Fix lirc plugin dependency checks (1.12 KB, patch)
2017-08-14 08:42 UTC, Bastien Nocera 		committed Details | Review

Description Jeremy Bicha 2017-08-13 23:19:13 UTC 
totem 3.25.90.1
lirc 0.10.0
meson 0.41.2
Ubuntu 17.10 Alpha

Totem doesn't detect the lirc development headers after the port to meson. 3.24.0 works fine.

I made 2 changes:
1. Check for 'lirc' instead of 'lirc_client' since the pkgconfig file is named lirc.pc
2. That still wasn't enough so I also dropped the lirc_init check.

Patch attached.
Comment 1 Jeremy Bicha 2017-08-13 23:19:16 UTC 
Created attachment 357530 [details] [review]
build: Fix lirc library detection
Comment 2 Bastien Nocera 2017-08-14 08:42:48 UTC 
Created attachment 357540 [details] [review]
lirc: Fix lirc plugin dependency checks

The pkg-config file is called lirc, not lirc_client (the name of the
library), and the function check didn't link against liblirc_client
either.
Comment 3 Bastien Nocera 2017-08-14 08:44:23 UTC 
Attachment 357540 [details] pushed as 09de336 - lirc: Fix lirc plugin dependency checks