After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786251 - build: use rpath when linking libgd
build: use rpath when linking libgd
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-08-13 19:51 UTC by Marinus Schraal
Modified: 2017-08-13 20:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: use rpath when linking libgd (2.14 KB, patch)
2017-08-13 19:51 UTC, Marinus Schraal 		committed Details | Review
build: remove duplicate entry (805 bytes, patch)
2017-08-13 19:52 UTC, Marinus Schraal 		committed Details | Review

Description Marinus Schraal 2017-08-13 19:51:11 UTC 
Some systems (Gentoo for one) can have gd (the gfx library) installed 
and it has a library conveniently named libgd. This clashes with the 
subproject libgd if the rpath isn't set for the plugins and libide 
making use of it. Resulting in the wrong so being loaded and missing 
symbols.

Much thanks to nirbheek for his input in this matter.
Comment 1 Marinus Schraal 2017-08-13 19:51:15 UTC 
Created attachment 357526 [details] [review]
build: use rpath when linking libgd

Add the builder libdir as rpath to the plugins and libide using the
internal libgd. Preventing a clash with the system-wide library with the
same name.
Comment 2 Marinus Schraal 2017-08-13 19:52:43 UTC 
Created attachment 357527 [details] [review]
build: remove duplicate entry
Comment 3 Patrick Griffis (tingping) 2017-08-13 19:57:42 UTC 
Review of attachment 357527 [details] [review]:

Yup
Comment 4 Patrick Griffis (tingping) 2017-08-13 19:59:43 UTC 
Review of attachment 357526 [details] [review]:

You could probably use `pkglibdir` rather than `pkglibdir_abs` but sounds good.
Comment 5 Christian Hergert 2017-08-13 20:17:03 UTC 
Lovely, thanks for taking the time to research and put the patches together!

Attachment 357526 [details] pushed as 3c91db0 - build: use rpath when linking libgd
Attachment 357527 [details] pushed as 3b8fc65 - build: remove duplicate entry