After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786213 - tracker-extract: Turn a runtime warning into a compile-time failure
tracker-extract: Turn a runtime warning into a compile-time failure
Status: RESOLVED FIXED
Product: tracker
Classification: Core
Component: Miners
unspecified
Other All
: Normal normal
: ---
Assigned To: tracker-general
tracker-general
Depends on:
Blocks:
 
 
Reported: 2017-08-12 21:12 UTC by Philip Withnall
Modified: 2017-08-13 20:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
tracker-extract: Turn a runtime warning into a compile-time failure (1.38 KB, patch)
2017-08-12 21:12 UTC, Philip Withnall 		committed Details | Review

Description Philip Withnall 2017-08-12 21:12:22 UTC 
Trivial patch attached.
Comment 1 Philip Withnall 2017-08-12 21:12:26 UTC 
Created attachment 357493 [details] [review]
tracker-extract: Turn a runtime warning into a compile-time failure

If we can’t work out the host byte order at compile time, all this code
is doomed to failure anyway. Might as well explode at compilation time
rather than runtime.

Signed-off-by: Philip Withnall <withnall@endlessm.com>
Comment 2 Carlos Garnacho 2017-08-13 09:25:09 UTC 
Comment on attachment 357493 [details] [review]
tracker-extract: Turn a runtime warning into a compile-time failure

Makes complete sense, nothing good will happen indeed if we spuriously return 0 in those places.
Comment 3 Philip Withnall 2017-08-13 20:15:39 UTC 
Attachment 357493 [details] pushed as 7a02f59 - tracker-extract: Turn a runtime warning into a compile-time failure