After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786202 - Patch for libchipcard-sdk fails
Patch for libchipcard-sdk fails
Status: RESOLVED FIXED
Product: GnuCash
Classification: Other
Component: Build system
unspecified
Other Mac OS
: Normal normal
: ---
Assigned To: gnucash-core-maint
gnucash-core-maint
Depends on:
Blocks:
 
 
Reported: 2017-08-12 16:47 UTC by Lee Read
Modified: 2018-06-29 23:58 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Lee Read 2017-08-12 16:47:36 UTC
The patch for libchipcard-sdk includes a hardcoded path to development environment:

https://github.com/Gnucash/gnucash-on-osx/blob/master/patches/libchipcard-sdk.patch#L1

Note, that I am uncertain if this patch is still necessary, I did skip the patch and the build continued.  I am on OSX 10.12.6.
Comment 1 John Ralls 2017-08-12 17:25:13 UTC
Show me the error you got. Patch should ignore that line, it's just a "memo" describing how the diff was generated. The --- and +++ lines are the ones that have the path that patch cares about.
Comment 2 Lee Read 2017-08-12 18:55:12 UTC
Ah, good to know, thanks. Here is what I get:

--[begin dump]--
*** Applying patch https://raw.githubusercontent.com/gnucash/gnucash-on-osx/master/patches/libchipcard-sdk.patch *** [44/69]
patch -p0 < "/Users/gnucash/.cache/jhbuild/libchipcard-sdk.patch"
can't find file to patch at input line 4
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff -c /Users/john/Development/Gnucash-Build/Gnucash-master-git/src/libchipcard-5.0.4/configure.ac\~ /Users/john/Development/Gnucash-Build/Gnucash-master-git/src/libchipcard-5.0.4/configure.ac
|--- a/configure.ac	Tue Dec 15 06:46:03 2015
|+++ b/configure.ac	Mon Mar 13 13:43:03 2017
--------------------------
File to patch:
--[end dump]--
Comment 3 John Ralls 2017-08-13 20:12:53 UTC
Libchipcard is in gnucash-on-osx, not gtk-osx-build so reassigning to GnuCash.
Also, it's fixed.
Comment 4 Lee Read 2017-08-13 21:03:31 UTC
Ooops. And thanks!
Comment 5 John Ralls 2018-06-29 23:58:38 UTC
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=786202. Please update any external references or bookmarks.