After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786195 - [PATCH] Python demos - Python 3 compatibility, Silence PyGI warnings, Fix MAP_PROJECTION_MERCATOR, flake8
[PATCH] Python demos - Python 3 compatibility, Silence PyGI warnings, Fix MAP...
Status: RESOLVED FIXED
Product: libchamplain
Classification: Core
Component: General
0.12.x
Other Linux
: Normal normal
: ---
Assigned To: libchamplain-maint
libchamplain-maint
Depends on:
Blocks:
 
 
Reported: 2017-08-12 10:28 UTC by Chris Mayo
Modified: 2017-08-22 21:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Make launcher-gtk.py Python 3 compatible (1.05 KB, patch)
2017-08-12 10:28 UTC, Chris Mayo 		none Details | Review
Silence PyGI version warnings for Python demos (2.67 KB, patch)
2017-08-12 10:29 UTC, Chris Mayo 		none Details | Review
Fix MapProjection attribute error for 'MAP_PROJECTION_MERCATOR' (831 bytes, patch)
2017-08-12 10:29 UTC, Chris Mayo 		none Details | Review
Implement flake8 suggestions for Python demos (5.43 KB, patch)
2017-08-12 10:29 UTC, Chris Mayo 		none Details | Review

Description Chris Mayo 2017-08-12 10:28:13 UTC 
Four separate patches attached in order:

- Make launcher-gtk.py Python 3 compatible
- Silence PyGI version warnings for Python demos
- Fix MapProjection attribute error for 'MAP_PROJECTION_MERCATOR'
- Implement flake8 suggestions for Python demos
Comment 1 Chris Mayo 2017-08-12 10:28:57 UTC 
Created attachment 357467 [details] [review]
Make launcher-gtk.py Python 3 compatible
Comment 2 Chris Mayo 2017-08-12 10:29:02 UTC 
Created attachment 357468 [details] [review]
Silence PyGI version warnings for Python demos
Comment 3 Chris Mayo 2017-08-12 10:29:06 UTC 
Created attachment 357469 [details] [review]
Fix MapProjection attribute error for 'MAP_PROJECTION_MERCATOR'
Comment 4 Chris Mayo 2017-08-12 10:29:10 UTC 
Created attachment 357470 [details] [review]
Implement flake8 suggestions for Python demos
Comment 5 Jiri Techet 2017-08-22 21:45:02 UTC 
Thanks Chris for the patches and sorry for the delay. I haven't tried the python demos for a while and wasn't aware of those various warnings. Your patches look good and I also tried them both with python 2 and 3 and everything runs nicely. Merged.