After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786194 - Doesn't build with required minimum version of gtk+
Doesn't build with required minimum version of gtk+
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
3.26.x
Other Linux
: Normal minor
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-08-12 09:52 UTC by António Fernandes
Modified: 2017-08-12 10:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
build: Raise gtk+ minimum version requirement (675 bytes, patch)
2017-08-12 09:54 UTC, António Fernandes
none Details | Review
build: Raise gtk+ minimum version requirement (884 bytes, patch)
2017-08-12 10:48 UTC, António Fernandes
committed Details | Review

Description António Fernandes 2017-08-12 09:52:33 UTC
Since commit 1d166b5e3b34195efe04df950a3f5397c2c99ef7 we use the
function gtk_flow_box_get_child_at_pos, which was introduced in
gtk+ 3.22.6. But our gtk+ requirement was still >=3.21.6.

Attaching a patch to raise required minimum gtk+ version to 3.22.6.
Comment 1 António Fernandes 2017-08-12 09:54:26 UTC
Created attachment 357466 [details] [review]
build: Raise gtk+ minimum version requirement
Comment 2 Ernestas Kulik 2017-08-12 10:34:59 UTC
Review of attachment 357466 [details] [review]:

Looks fine, thanks!
Comment 3 António Fernandes 2017-08-12 10:48:11 UTC
Created attachment 357471 [details] [review]
build: Raise gtk+ minimum version requirement

Adding missing author line and description (gitg ate them)
Comment 4 Ernestas Kulik 2017-08-12 10:50:20 UTC
Review of attachment 357471 [details] [review]:

Second time’s the charm, or something.
Comment 5 Ernestas Kulik 2017-08-12 10:57:12 UTC
Attachment 357471 [details] pushed as 21f7f42 - build: Raise gtk+ minimum version requirement