After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786172 - videoutilsprivate: fill more video fields.
videoutilsprivate: fill more video fields.
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other All
: Normal enhancement
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-08-11 18:58 UTC by Mathieu Duponchelle
Modified: 2017-08-14 10:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
videoutilsprivate: fill more video fields. (1.65 KB, patch)
2017-08-11 18:58 UTC, Mathieu Duponchelle
committed Details | Review

Description Mathieu Duponchelle 2017-08-11 18:58:31 UTC
__gst_video_element_proxy_caps is called by
__gst_video_element_proxy_getcaps with caps set to the caps
allowed downstream. As we didn't set colorimetry or
chroma-site on the resulting caps, upstream considered it
possible to use whatever values it wanted, leading to
not negotiated errors later on.

As the description for that function is:
"Takes caps and copies its video fields to tmpl_caps",
it seems legitimate to set these fields there.
Comment 1 Mathieu Duponchelle 2017-08-11 18:58:36 UTC
Created attachment 357439 [details] [review]
videoutilsprivate: fill more video fields.
Comment 2 Mathieu Duponchelle 2017-08-14 10:43:27 UTC
Attachment 357439 [details] pushed as 28943c4 - videoutilsprivate: fill more video fields.