GNOME Bugzilla – Bug 786167
macOS: Don't require shared-mime-info
Last modified: 2017-10-04 12:23:00 UTC
Created attachment 357431 [details] [review] macOS: Don't require shared-mime-info Since commit 2c2162c86d4f710007cfffbc582a1f0ce8740725 shared-mime-info is required for building gdk-pixbuf, except on Windows. This disables it on macOS as well to restore the old behaviour.
Review of attachment 357431 [details] [review]: the prefix for the commit subject would be "build: ". You'll also need to modify the meson.build file for the same problem: # On non-Windows systems we always required shared-mime-info and GIO if host_machine.system() != 'windows' shared_mime_dep = dependency('shared-mime-info') gdk_pixbuf_conf.set('GDK_PIXBUF_USE_GIO_MIME', 1) else shared_mime_dep = [] endif
Created attachment 357568 [details] [review] build: Don't require shared-mime-info on macOS
Review of attachment 357568 [details] [review]: Sure.
Comment on attachment 357568 [details] [review] build: Don't require shared-mime-info on macOS Thanks
This patch broke lots of configure checks on darwin, because $os_win32 is no longer defined. Checks like `test x$os_win32 = xno` now have the opposite result than before. The easy fix would be to add the line `os_win32=no` also to the darwin conditional. Should I open a new bug report for this?
oops, sorry :/ continuing here is fine imo.
Created attachment 359937 [details] [review] build: fix undefined os_win32 var on macOS
In the future, and if you don't have rights to reopen the bug, please file a new one. Otherwise we have patches in closed bugs which aren't tracked anywhere. Reopening.
And please try and avoid committing without reviews.
*** Bug 787315 has been marked as a duplicate of this bug. ***