After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786147 - No proxy information in case of proxy with HTTP auth
No proxy information in case of proxy with HTTP auth
Status: RESOLVED OBSOLETE
Product: libsoup
Classification: Core
Component: HTTP Transport
unspecified
Other Linux
: Normal normal
: ---
Assigned To: libsoup-maint@gnome.bugs
libsoup-maint@gnome.bugs
Depends on:
Blocks:
 
 
Reported: 2017-08-11 10:50 UTC by Carlos Garcia Campos
Modified: 2018-09-21 16:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
WIP (9.89 KB, patch)
2017-08-11 12:13 UTC, Carlos Garcia Campos
none Details | Review

Description Carlos Garcia Campos 2017-08-11 10:50:21 UTC
The authenticate signal is emitted when the proxy requires creadentials, but the SoupMessage and the SoupAuth passed to the signal contain the uri and host of the original request, not the proxy one. This means that, for example WebKitGTK shows the HTTP auth dialog claiming that the URL foo is password protected, when that's not true, because it's the proxy the one using HTTP auth not the request URL. Maybe we could extend SoupAuth to return proxy information, or fix it to use the proxy host and also add soup_auth_get_port()
Comment 1 Carlos Garcia Campos 2017-08-11 12:13:57 UTC
Created attachment 357404 [details] [review]
WIP

This is a WIP patch just to get feedback, if this approach is ok I'll finish it.
Comment 2 Claudio Saavedra 2018-01-09 15:23:08 UTC
With my limited understanding of this, considering that soup_auth_is_for_proxy() is documented as "Tests whether or not auth is associated with a proxy server rather than an "origin" server.", the fact that the getters SoupAuth are all for the "origin" server regardless of the purpose of SoupAuth is a bit misleading. I don't think changing it to return the proxy info instead would be a good idea at this point, though, as that would break the current behavior. Extending SoupAuth, as in your patch, to allow checking the proxy seems like a better approach to me.
Comment 3 Jan-Michael Brummer 2018-05-01 08:44:33 UTC
This looks promising as i encounter this issue myself at the moment. The patch could (with some changes) also be used for gss-negotiate where the proxy uri information is missing. See: https://bugzilla.gnome.org/show_bug.cgi?id=601031
Comment 4 GNOME Infrastructure Team 2018-09-21 16:32:12 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/libsoup/issues/105.