After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786131 - String suggestions for translatable strings
String suggestions for translatable strings
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: Documentation
git master
Other Linux
: Normal minor
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-08-10 23:20 UTC by Anders Jonsson
Modified: 2017-08-11 14:50 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Anders Jonsson 2017-08-10 23:20:56 UTC
Hi,
I saw some strings that look like they could need some minor adjustments. See below for strings and suggestions.


>#: ../clients/common/settings-docs.c.in:11
>#: ../clients/common/settings-docs.c.in:92
>"If the value contains more then one additional MAC addresses"

This should be "more *THAN* one"


>#: ../clients/common/settings-docs.c.in:228
>"derived from  hardware address."

Here is a doubled space in front of "hardware"




#: ../libnm-core/nm-setting-bond.c:645
#, c-format
msgid "'%s' is not a valid for '%s' option: %s"

This looks a bit strange to me. I would either write "is not valid for", or add a suitable noun so that it is "is not a valid <noun> for"
Comment 1 Thomas Haller 2017-08-11 09:12:56 UTC
fixed on master: https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=752afada0bcdc22bfbcd253bcdaa0fbd8e830791

Thanks for the report!!
Comment 2 Piotr Drąg 2017-08-11 14:16:48 UTC
I’m not sure this:

 #: ../libnm-core/nm-setting-bond.c:629
 #, c-format
-msgid "'%s' is not a valid for '%s' option: %s"
+msgid "'%s' is not valid for the '%s' option: %s"
 msgstr "„%s” nie jest prawidłową opcją dla „%s”: %s"

is the best option here. I need to reword the translation, but now I don’t have the fuzzy mark to remember it when the time comes. It’s best to avoid changing .po files altogether.
Comment 3 Thomas Haller 2017-08-11 14:21:07 UTC
(In reply to Piotr Drąg from comment #2)
> I’m not sure this:
> 
>  #: ../libnm-core/nm-setting-bond.c:629
>  #, c-format
> -msgid "'%s' is not a valid for '%s' option: %s"
> +msgid "'%s' is not valid for the '%s' option: %s"
>  msgstr "„%s” nie jest prawidłową opcją dla „%s”: %s"
> 
> is the best option here. I need to reword the translation, but now I don’t
> have the fuzzy mark to remember it when the time comes. It’s best to avoid
> changing .po files altogether.

I wouldn't think that you need to reword the translation. The previous sentence was grammatically wrong(*), but the meaning was the same. So I would think that the previous translation glossed over the grammar and is still correct (without need for rewording the translation).


(*) the new form isn't poetry either, but better.
Comment 4 Piotr Drąg 2017-08-11 14:24:41 UTC
The grammar must have confused me, because it’s translated wrong. :)
Comment 5 Thomas Haller 2017-08-11 14:42:33 UTC
(In reply to Piotr Drąg from comment #4)
> The grammar must have confused me, because it’s translated wrong. :)

The problem is, many languages don't have very active translators. So, breaking translations (while fixing spelling) seems a major annoyance, that could be avoided doing search+replace in po directory.

But OK. I try to avoid touching translations in future. Ok? :)
Comment 6 Piotr Drąg 2017-08-11 14:50:13 UTC
(In reply to Thomas Haller from comment #5)
> The problem is, many languages don't have very active translators. So,
> breaking translations (while fixing spelling) seems a major annoyance, that
> could be avoided doing search+replace in po directory.
> 

Minor spelling and typo fixes are fine.

We could bring more translators if someone figured out how to integrate damned-lies with fd.o.

> But OK. I try to avoid touching translations in future. Ok? :)

Thank you, much appreciated!