After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786119 - va.h already includes VA sub APIs
va.h already includes VA sub APIs
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer-vaapi
unspecified
Other All
: Normal normal
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-08-10 17:28 UTC by Víctor Manuel Jáquez Leal
Modified: 2017-08-16 10:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
build: check for va_vpp.h (2.67 KB, patch)
2017-08-10 17:28 UTC, Víctor Manuel Jáquez Leal
committed Details | Review
build: consolidate the VA sub API includes (8.69 KB, patch)
2017-08-10 17:28 UTC, Víctor Manuel Jáquez Leal
committed Details | Review
libs: encoder: remove va.h include (3.38 KB, patch)
2017-08-10 17:28 UTC, Víctor Manuel Jáquez Leal
committed Details | Review
libs: utils: remove va.h include in header (3.07 KB, patch)
2017-08-10 17:28 UTC, Víctor Manuel Jáquez Leal
committed Details | Review
libs: utils: move gstvaapisurface.h to private headers (3.00 KB, patch)
2017-08-10 17:29 UTC, Víctor Manuel Jáquez Leal
committed Details | Review
libs: remove unused header (7.72 KB, patch)
2017-08-10 17:29 UTC, Víctor Manuel Jáquez Leal
committed Details | Review

Description Víctor Manuel Jáquez Leal 2017-08-10 17:28:29 UTC
These patches cleans up the include of VA sub APIs, because since VA-API 0.37
they are included in va.h, since there is no need to include them again.
Comment 1 Víctor Manuel Jáquez Leal 2017-08-10 17:28:36 UTC
Created attachment 357345 [details] [review]
build: check for va_vpp.h

Thus, in config.h the macro HAVE_VA_VA_VPP_H is defined. This will
allow us to handle the inclusion of the header better.
Comment 2 Víctor Manuel Jáquez Leal 2017-08-10 17:28:43 UTC
Created attachment 357346 [details] [review]
build: consolidate the VA sub API includes

Include all VA sub APIs headers in a single point (gstvaapicompat.h),
since they are all already included in va.h after VA-API 0.38.
Comment 3 Víctor Manuel Jáquez Leal 2017-08-10 17:28:50 UTC
Created attachment 357347 [details] [review]
libs: encoder: remove va.h include

Since it is already managed by gstvaapicompat.h
Comment 4 Víctor Manuel Jáquez Leal 2017-08-10 17:28:57 UTC
Created attachment 357348 [details] [review]
libs: utils: remove va.h include in header

And include gstvaapicompat.h in the C files, since the VA-API is not
exposed in the headers.
Comment 5 Víctor Manuel Jáquez Leal 2017-08-10 17:29:05 UTC
Created attachment 357349 [details] [review]
libs: utils: move gstvaapisurface.h to private headers

Since the utils don't expose API defined in gstvaapisource.h, it is
moved to their private headers where they are used.
Comment 6 Víctor Manuel Jáquez Leal 2017-08-10 17:29:11 UTC
Created attachment 357350 [details] [review]
libs: remove unused header

Since libgstvaapi is not distributed, there is no need to check for
private header inclusion. Thus removing it.
Comment 7 Víctor Manuel Jáquez Leal 2017-08-14 14:38:17 UTC
Attachment 357345 [details] pushed as 1789c60 - build: check for va_vpp.h
Attachment 357346 [details] pushed as 9891f1a - build: consolidate the VA sub API includes
Attachment 357347 [details] pushed as aaca75f - libs: encoder: remove va.h include
Attachment 357348 [details] pushed as 3f9ad1f - libs: utils: remove va.h include in header
Attachment 357349 [details] pushed as 3b8b2ff - libs: utils: move gstvaapisurface.h to private headers
Attachment 357350 [details] pushed as a07ff96 - libs: remove unused header