After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786117 - With new panel design, no panel is preselected on start.
With new panel design, no panel is preselected on start.
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: shell
git master
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-08-10 15:25 UTC by Hussam Al-Tayeb
Modified: 2017-08-16 19:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
window: Don't accidentally destroy panels when showing overview (2.26 KB, patch)
2017-08-16 19:39 UTC, Georges Basile Stavracas Neto
committed Details | Review

Description Hussam Al-Tayeb 2017-08-10 15:25:47 UTC
When starting gnome-control-center with the new design, the Bluetooth panel is highlighted but not selected. Look at the right and notice that the bluetooth panel area is empty. I have to click on "Bluetooth" again.
This is the first issue.

In addition, pressing the down arrow to highlight "Backgrounds" doesn't select it. it just gets highlighted. pressing enter correctly selects it. This is likely the cause of the first issue.

This means moving between panels using the keyboard requires two actions. 1) up arrow or down arrow. 2) The 'Enter' key.
Comment 1 Mohammed Sadiq 2017-08-10 16:37:58 UTC
I thought about reporting this. There are a few issues with to think regarding this.

1. By default, when g-c-c is opened, the first panel from the panel list (which is alphabetically ordered) is opened. So in some Languages it might be, say, "Region & Language". This panel is really slow to open (seems like some critical part of the code is run in main thread). So this means that opening g-c-c will be very slow in that case.

  IMHO, the best panel to be selected by default would be the most used panel by the user.

2. As the continuation of the above point, automatically selecting a panel when the highlight is over the panel item may be less efficient. A work around to avoid pressing the Enter key may be, select the panel after some delay.

Thanks
Comment 2 Hussam Al-Tayeb 2017-08-10 16:59:38 UTC
How about the following?

1) Select the last used or most used panel by default. A user seeing an empty "Bluetooth" panel by default may think it is intentionally empty.

2) Keep the highlight at initially selected panel "A" but draw a dotted selection box around panel "B" when navigating to it with the keyboard. Then when pressing enter, the highlight is moved to the newly selected panel "B". This keeps the requirement of pressing Enter but makes is more discoverable.

The second part is not really a major issue but as I said, a empty "Bluetooth" panel may look odd at first glance.
Comment 3 Alexander Mikhaylenko 2017-08-12 11:31:37 UTC
Hussam Al-Tayeb:
Allan Day has written a list of design problems with current implementation:
https://etherpad.gnome.org/p/settings-shell

When the first line is fixed, the order will be the same in all locales, so it'll be safe to just open the first panel, which will be Wi-Fi.
Comment 4 Alexander Mikhaylenko 2017-08-12 11:35:55 UTC
Sorry, I mean to reply to comment 1
Comment 5 Hussam Al-Tayeb 2017-08-12 15:51:11 UTC
(In reply to Mikhaylenko Alexander from comment #3)
> Hussam Al-Tayeb:
> Allan Day has written a list of design problems with current implementation:
> https://etherpad.gnome.org/p/settings-shell
> 
> When the first line is fixed, the order will be the same in all locales, so
> it'll be safe to just open the first panel, which will be Wi-Fi.

Will the default panel be selected?
Comment 6 Alexander Mikhaylenko 2017-08-12 15:55:08 UTC
No. Just saying that opening the first panel in the list becomes a safe variant, if that's what'll be decided.

I accidentally replied to you, I meant to reply to comment 1 that raised this concern. :)
Comment 7 Hussam Al-Tayeb 2017-08-12 16:54:26 UTC
Ah ok.
Another idea I had is maybe they can use a welcome screen by default and have no panel highlighted or selected by default.
Comment 8 Georges Basile Stavracas Neto 2017-08-16 19:39:23 UTC
Created attachment 357750 [details] [review]
window: Don't accidentally destroy panels when showing overview

When passing --overview, Settings' new shell window accidentally
removes the newly selected panel.

We're considering the possibility of adding an overview page but,
since that won't happen for the next release, let's just make sure
something happens for now.

Fix that by simply changing the panel list view, which selects the
Wi-Fi panel if the user was in another view.
Comment 9 Georges Basile Stavracas Neto 2017-08-16 19:41:31 UTC
Attachment 357750 [details] pushed as b8fbf50 - window: Don't accidentally destroy panels when showing overview