After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786083 - build: Correctly define variable warn_flags
build: Correctly define variable warn_flags
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: general
3.25.x
Other All
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-08-10 04:55 UTC by Jeremy Bicha
Modified: 2017-08-10 09:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: Correctly define variable warn_flags (905 bytes, patch)
2017-08-10 04:55 UTC, Jeremy Bicha 		needs-work Details | Review
build: Fix failure when not building a debug version (1.13 KB, patch)
2017-08-10 09:15 UTC, Bastien Nocera 		committed Details | Review

Description Jeremy Bicha 2017-08-10 04:55:50 UTC 
Here's a patch to fix this error when building on Ubuntu:


Meson encountered an error in file src/backend/meson.build, line 90, column 0:
Unknown variable "warn_flags".
Died at /usr/share/perl5/Debian/Debhelper/Buildsystem/meson.pm line 61.
Comment 1 Jeremy Bicha 2017-08-10 04:55:53 UTC 
Created attachment 357319 [details] [review]
build: Correctly define variable warn_flags
Comment 2 Bastien Nocera 2017-08-10 08:40:13 UTC 
Review of attachment 357319 [details] [review]:

Can you please fix the commit subject? It contains no information about the reason why the problem happened or how it was fixed.

build: Fix failure when not building a debug version

<insert error>

The warn_flags would not be initialised when the build was not a
debug build. Initialise the variable outside the debug conditional.
Comment 3 Bastien Nocera 2017-08-10 09:15:14 UTC 
Created attachment 357329 [details] [review]
build: Fix failure when not building a debug version

Meson encountered an error in file src/backend/meson.build, line 90, column 0:
Unknown variable "warn_flags".

The warn_flags would not be initialised when the build was not a
debug build. Initialise the variable outside the debug conditional.
Comment 4 Bastien Nocera 2017-08-10 09:19:29 UTC 
Attachment 357329 [details] pushed as 54e7c7f - build: Fix failure when not building a debug version