After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786071 - Fix library naming with the meson build system
Fix library naming with the meson build system
Status: RESOLVED FIXED
Product: totem-pl-parser
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: totem-pl-parser-maint
totem-pl-parser-maint
Depends on:
Blocks:
 
 
Reported: 2017-08-09 20:37 UTC by Nirbheek Chauhan
Modified: 2017-08-10 08:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
meson: Correctly set the version kwarg for libraries (2.50 KB, patch)
2017-08-09 20:37 UTC, Nirbheek Chauhan
committed Details | Review

Description Nirbheek Chauhan 2017-08-09 20:37:48 UTC
This derives the library versioning from the lt_version and matches what it was with Autotools to preserve ABI. Perhaps with the next ABI break this can be decoupled and the library versioning can be derived from the project version instead.
Comment 1 Nirbheek Chauhan 2017-08-09 20:37:54 UTC
Created attachment 357304 [details] [review]
meson: Correctly set the version kwarg for libraries

This ensures that a libtotem-plparser*.so.X symlink is created to the
libtotem-plparser*.so.X.Y.Z library, and that the values of X, Y, and
Z match the library naming used by the old Autotools build.
Comment 2 Bastien Nocera 2017-08-10 08:52:26 UTC
Attachment 357304 [details] pushed as 9ccc3c7 - meson: Correctly set the version kwarg for libraries