GNOME Bugzilla – Bug 786069
Vertical scrollbar looks bad in Tweaks 3.25.4
Last modified: 2017-08-10 23:05:36 UTC
With Tweaks 3.25.4, the Windows panel has too many options so there is a vertical scrollbar. That's fine except Tweaks has some unusual UI behind the scenes and the scrollbar looks really bad. As a workaround for 3.26, I am proposing moving the Titlebar options somewhere else. I am attaching a commit (which I also pushed to wip/move-titlebar-tweaks ) that moves the Titlebar tweaks to the Top Bar panel. Another option is to make a new top level panel named Titlebar. Or something. I am delaying the 3.25.90 release for this issue because I'd prefer to try to get as much UI reshuffling or potential string additions as possible done before the release.
Created attachment 357294 [details] [review] Move Titlebar tweaks from Windows to Top Bar To work around vertical scrolling issue seen in too-long Windows panel
I discussed this with Allan Day in #gnome-design today. We decided to revert the Window Focus listbox introduced in 3.25 back to the combobox used in 3.24 since it uses less space. I also removed the HiDPI section (see https://bugzilla.gnome.org/785610 ) since it is more or less obsolete with the new Scaling feature in gnome-control-center 3.25. This frees up enough space to eliminate the vertical scrollbar without needing to move anything to a different panel.
Created attachment 357355 [details] [review] main_content: Set margin deeper in the widget tree Reopening, because I think I have got a trivial fix for the scrollbar showing up in the wrong place. The margin is being set on the whole stack widget, which is parent of the scrolled window. That's why the scrollbar is affected by the margin too. Instead, if we set the margin on the listbox, inside the scrolled window, the scrollbar is "pushed" to the edge of the window, as would be expected.
Review of attachment 357355 [details] [review]: Thank you! Let me know if you need me to push this to git for you. I'll go ahead and make a 3.25.90.1 release soon with this commit and reverting the Focus Mode change I made earlier today, but I think I'll not add back the Hi-DPI section now.
Since we're kind of late in the week for UI changes already and because I didn't know whether you have git commit rights, I'm pushing this for you now. Thanks! Attachment 357355 [details] pushed as ab83958 - main_content: Set margin deeper in the widget tree