GNOME Bugzilla – Bug 786035
Make it easier to split loaders installation
Last modified: 2018-05-22 13:23:51 UTC
.
Created attachment 357236 [details] [review] build: Sort libpng versions
Created attachment 357237 [details] [review] build: Add enable_boutique_loaders option for Meson Those loaders, without dependencies, are not generally useful for applications, only for image-viewing applications. They are enabled by default for now, but should be disabled in Flatpak runtimes, with the applications shipping the loaders themselves.
Created attachment 357238 [details] [review] core: Split off the initialisation sections Separate the builtin loaders setup from the external loaders initialisation from the loaders.cache file.
Created attachment 357239 [details] [review] core: Pass module_file path as an argument This should allow applications to install gdk-pixbuf modules in a separate directory from the system location.
Created attachment 357240 [details] [review] core: Add gdk_pixbuf_init_modules() for applications gdk_pixbuf_init_modules() should be used by applications which want to have gdk-pixbuf loader modules install in a separate path, usually in the application's library directory.
Created attachment 357241 [details] [review] core: Add library option Build the library by default, but allow disabling it so that application can install just the loaders to extend an existing gdk-pixbuf installation.
Review of attachment 357236 [details] [review]: ++
Review of attachment 357237 [details] [review]: ++
Review of attachment 357238 [details] [review]: ::: gdk-pixbuf/gdk-pixbuf-io.c @@ +569,3 @@ +gdk_pixbuf_io_init_builtin (void) +{ + GdkPixbufModule *builtin_module ; Nitpick: Space before the `;`.
Review of attachment 357239 [details] [review]: ::: gdk-pixbuf/gdk-pixbuf-io.c @@ +646,3 @@ gdk_pixbuf_io_init (void) { + g_autofree char *module_file; Missing `= NULL` initialisation.
Review of attachment 357240 [details] [review]: Nitpick in the commit message: s/install/installed/ ::: gdk-pixbuf/gdk-pixbuf-io.c @@ +570,3 @@ + * file present inside that directory. + * + * This is to be used by application that want to ship certain loaders Nitpick: s/application/applications/ Would be useful if you also gave an example of _why_ applications might want to do this. @@ +571,3 @@ + * + * This is to be used by application that want to ship certain loaders + * in a different location from the system ones. Needs a `Since: 2.36.x` line @@ +576,3 @@ +gdk_pixbuf_init_modules (const char *path) +{ + g_autofree char *filename; Initialise to NULL.
Review of attachment 357241 [details] [review]: ++
Created attachment 358244 [details] [review] core: Pass module_file path as an argument This should allow applications to install gdk-pixbuf modules in a separate directory from the system location.
Created attachment 358245 [details] [review] core: Add gdk_pixbuf_init_modules() for applications gdk_pixbuf_init_modules() should be used by applications which want to have gdk-pixbuf loader modules install in a separate path, usually in the application's library directory.
Comment on attachment 357236 [details] [review] build: Sort libpng versions Attachment 357236 [details] pushed as 2c6404f - build: Sort libpng versions
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gdk-pixbuf/issues/65.