After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786035 - Make it easier to split loaders installation
Make it easier to split loaders installation
Status: RESOLVED OBSOLETE
Product: gdk-pixbuf
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gdk-pixbuf-maint
gdk-pixbuf-maint
Depends on:
Blocks:
 
 
Reported: 2017-08-09 09:22 UTC by Bastien Nocera
Modified: 2018-05-22 13:23 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
build: Sort libpng versions (1.33 KB, patch)
2017-08-09 09:22 UTC, Bastien Nocera
committed Details | Review
build: Add enable_boutique_loaders option for Meson (3.31 KB, patch)
2017-08-09 09:22 UTC, Bastien Nocera
accepted-commit_now Details | Review
core: Split off the initialisation sections (6.16 KB, patch)
2017-08-09 09:22 UTC, Bastien Nocera
accepted-commit_now Details | Review
core: Pass module_file path as an argument (2.07 KB, patch)
2017-08-09 09:22 UTC, Bastien Nocera
none Details | Review
core: Add gdk_pixbuf_init_modules() for applications (1.85 KB, patch)
2017-08-09 09:23 UTC, Bastien Nocera
none Details | Review
core: Add library option (2.41 KB, patch)
2017-08-09 09:23 UTC, Bastien Nocera
accepted-commit_now Details | Review
core: Pass module_file path as an argument (2.08 KB, patch)
2017-08-23 15:22 UTC, Bastien Nocera
none Details | Review
core: Add gdk_pixbuf_init_modules() for applications (2.33 KB, patch)
2017-08-23 15:28 UTC, Bastien Nocera
none Details | Review

Description Bastien Nocera 2017-08-09 09:22:33 UTC
.
Comment 1 Bastien Nocera 2017-08-09 09:22:39 UTC
Created attachment 357236 [details] [review]
build: Sort libpng versions
Comment 2 Bastien Nocera 2017-08-09 09:22:44 UTC
Created attachment 357237 [details] [review]
build: Add enable_boutique_loaders option for Meson

Those loaders, without dependencies, are not generally useful
for applications, only for image-viewing applications. They
are enabled by default for now, but should be disabled in Flatpak
runtimes, with the applications shipping the loaders themselves.
Comment 3 Bastien Nocera 2017-08-09 09:22:50 UTC
Created attachment 357238 [details] [review]
core: Split off the initialisation sections

Separate the builtin loaders setup from the external loaders
initialisation from the loaders.cache file.
Comment 4 Bastien Nocera 2017-08-09 09:22:56 UTC
Created attachment 357239 [details] [review]
core: Pass module_file path as an argument

This should allow applications to install gdk-pixbuf modules
in a separate directory from the system location.
Comment 5 Bastien Nocera 2017-08-09 09:23:02 UTC
Created attachment 357240 [details] [review]
core: Add gdk_pixbuf_init_modules() for applications

gdk_pixbuf_init_modules() should be used by applications which
want to have gdk-pixbuf loader modules install in a separate
path, usually in the application's library directory.
Comment 6 Bastien Nocera 2017-08-09 09:23:07 UTC
Created attachment 357241 [details] [review]
core: Add library option

Build the library by default, but allow disabling it so that
application can install just the loaders to extend an existing
gdk-pixbuf installation.
Comment 7 Philip Withnall 2017-08-17 14:00:23 UTC
Review of attachment 357236 [details] [review]:

++
Comment 8 Philip Withnall 2017-08-17 14:01:40 UTC
Review of attachment 357237 [details] [review]:

++
Comment 9 Philip Withnall 2017-08-17 14:03:30 UTC
Review of attachment 357238 [details] [review]:

::: gdk-pixbuf/gdk-pixbuf-io.c
@@ +569,3 @@
+gdk_pixbuf_io_init_builtin (void)
+{
+        GdkPixbufModule *builtin_module ;

Nitpick: Space before the `;`.
Comment 10 Philip Withnall 2017-08-17 14:05:34 UTC
Review of attachment 357239 [details] [review]:

::: gdk-pixbuf/gdk-pixbuf-io.c
@@ +646,3 @@
 gdk_pixbuf_io_init (void)
 {
+	g_autofree char *module_file;

Missing `= NULL` initialisation.
Comment 11 Philip Withnall 2017-08-17 14:09:34 UTC
Review of attachment 357240 [details] [review]:

Nitpick in the commit message: s/install/installed/

::: gdk-pixbuf/gdk-pixbuf-io.c
@@ +570,3 @@
+ * file present inside that directory.
+ *
+ * This is to be used by application that want to ship certain loaders

Nitpick: s/application/applications/

Would be useful if you also gave an example of _why_ applications might want to do this.

@@ +571,3 @@
+ *
+ * This is to be used by application that want to ship certain loaders
+ * in a different location from the system ones.

Needs a `Since: 2.36.x` line

@@ +576,3 @@
+gdk_pixbuf_init_modules (const char *path)
+{
+	g_autofree char *filename;

Initialise to NULL.
Comment 12 Philip Withnall 2017-08-17 14:12:43 UTC
Review of attachment 357241 [details] [review]:

++
Comment 13 Bastien Nocera 2017-08-23 15:22:14 UTC
Created attachment 358244 [details] [review]
core: Pass module_file path as an argument

This should allow applications to install gdk-pixbuf modules
in a separate directory from the system location.
Comment 14 Bastien Nocera 2017-08-23 15:28:32 UTC
Created attachment 358245 [details] [review]
core: Add gdk_pixbuf_init_modules() for applications

gdk_pixbuf_init_modules() should be used by applications which
want to have gdk-pixbuf loader modules install in a separate
path, usually in the application's library directory.
Comment 15 Bastien Nocera 2017-09-19 09:21:14 UTC
Comment on attachment 357236 [details] [review]
build: Sort libpng versions

Attachment 357236 [details] pushed as 2c6404f - build: Sort libpng versions
Comment 16 GNOME Infrastructure Team 2018-05-22 13:23:51 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gdk-pixbuf/issues/65.