After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 786009 - Alt+tab followed by alt+~ inconsistent behavior with down arrow key
Alt+tab followed by alt+~ inconsistent behavior with down arrow key
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: app-switcher
3.24.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2017-08-08 16:20 UTC by Didier Roche
Modified: 2017-09-20 05:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch for alt+<key above tab> more consistant behavior in switcher. (1.66 KB, patch)
2017-09-13 08:58 UTC, Didier Roche
none Details | Review
Make key-above-tab in switcher more consistent (1.51 KB, patch)
2017-09-14 07:34 UTC, Didier Roche
committed Details | Review

Description Didier Roche 2017-08-08 16:20:27 UTC
First, I want to hilight I completely understand the desired design behavior of Alt+tab being application switching while alt+~ beeing the per-application window switch.
I have also read https://bugzilla.gnome.org/show_bug.cgi?id=69748.

However, I think there is an inconsistent behavior when you want to only raise the last focused window of an application:
1. Press Alt+Tab until the switcher is visible and you go to the hilight the desired multi-window application. Keep alt pressed
2. a) if you press the down arrow key, the first window of that application is hilighted and you can raise only that instance if desired
   b) if you press key-above-tab (² or ~, depending on your keyboard configuration), however the second window of that application is hilighted, so you need to cycle back all the way down to first one to only raise that one.

I suggest that when the switcher is displayed, after an alt-tab with alt keep being pressed, the first key-above-tab press hilight the first window instead of the second (as if you pressed the down arrow key)

I'm happy to provide a patch for this if what I'm telling make sense to you.
Comment 1 Didier Roche 2017-08-08 16:24:55 UTC
the bug report I was referring to was missing one digit: https://bugzilla.gnome.org/show_bug.cgi?id=697480
Comment 2 Didier Roche 2017-09-13 08:58:17 UTC
Created attachment 359693 [details] [review]
Proposed patch for alt+<key above tab> more consistant behavior in switcher.
Comment 3 Florian Müllner 2017-09-13 15:45:30 UTC
Review of attachment 359693 [details] [review]:

One code style issue and the commit message should use shorter lines, otherwise looks good to me

::: js/ui/altTab.js
@@ +159,3 @@
     _keyPressHandler: function(keysym, action) {
         if (action == Meta.KeyBindingAction.SWITCH_GROUP) {
+            if (!this._thumbnailsFocused) {

Style nit: no braces
Comment 4 Didier Roche 2017-09-14 07:34:38 UTC
Created attachment 359763 [details] [review]
Make key-above-tab in switcher more consistent

Thanks for the review! Here we go. I changed the commit message as well.
Comment 5 Florian Müllner 2017-09-14 18:56:35 UTC
Review of attachment 359763 [details] [review]:

LGTM
Comment 6 Florian Müllner 2017-09-19 18:10:39 UTC
I don't know if you have push access, getting this off the list now.

Attachment 359763 [details] pushed as 9f0bb52 - Make key-above-tab in switcher more consistent
Comment 7 Didier Roche 2017-09-20 05:56:30 UTC
No, I don't have push access, thanks for sponsoring this Florian!