After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 785997 - Please don't bundle gtest
Please don't bundle gtest
Status: RESOLVED WONTFIX
Product: gparted
Classification: Other
Component: application
0.29.0
Other Linux
: Normal normal
: ---
Assigned To: gparted maintainers alias
gparted maintainers alias
Depends on:
Blocks:
 
 
Reported: 2017-08-08 13:48 UTC by Jeremy Bicha
Modified: 2017-10-18 20:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Jeremy Bicha 2017-08-08 13:48:53 UTC 
gparted 0.29.0 includes a copy of the gtest (Google Test Framework) source code.

According to Debian Policy [1], embedded code copies should not be used in Debian.

Please use the system-installed gtest instead of bundling the third-party code. gtest/googletest is already packaged in distros:
https://repology.org/metapackage/gtest/versions

[1] https://www.debian.org/doc/debian-policy/ch-source.html#s-embeddedfiles
Comment 1 Mike Fleetwood 2017-08-09 13:31:36 UTC 
1) The Google test FAQ says the opposite!

Why it is not recommended to install a pre-compiled copy of Google Test
(for example, into /usr/local)?
https://github.com/google/googletest/blob/master/googletest/docs/FAQ.md#why-is-it-not-recommended-to-install-a-pre-compiled-copy-of-google-test-for-example-into-usrlocal


2) Google test is distributed in GParted source but is not installed by
   the build system and should not be included in binary packages.
Comment 2 Mike Fleetwood 2017-10-17 12:42:13 UTC 
Closing this for reasons described in comment #1.
Comment 3 Jeremy Bicha 2017-10-17 15:13:40 UTC 
Sorry for not responding earlier. I contacted Debian maintainer Steve Robbins who replied:

"I'm too lazy to log into Gnome's bugzilla, but my comment is this: the Debian
package provides SOURCE code for gtest in /usr/src.  It's not a pre-compiled
binary, so the FAQ cited does not apply."
Comment 4 Mike Fleetwood 2017-10-18 20:03:42 UTC 
I have just looked at Fedora 26, and their gtest package installs a
compile library and header files.
    https://apps.fedoraproject.org/packages/gtest/contents/

Therefore GParted has to ship Google Test source to provide it on
distros which don't have a package to install the gtest source.