After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 785949 - display: Re-design the panel
display: Re-design the panel
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Display
unspecified
Other All
: Normal normal
: ---
Assigned To: Debarshi Ray
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-08-07 14:11 UTC by Rui Matos
Modified: 2017-08-09 17:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
display: Refactor night light widget instantiation (6.69 KB, patch)
2017-08-07 14:11 UTC, Rui Matos
committed Details | Review
display: Add some signals to the new configuration API (5.32 KB, patch)
2017-08-07 14:11 UTC, Rui Matos
committed Details | Review
display-config-dbus: Consider interlaced flag for similar modes (1.13 KB, patch)
2017-08-07 14:12 UTC, Rui Matos
committed Details | Review
shell: Add GtkListBox/Row derived types that do single row activations (2.73 KB, patch)
2017-08-07 14:12 UTC, Rui Matos
committed Details | Review
display: Re-design the panel (123.57 KB, patch)
2017-08-07 14:12 UTC, Rui Matos
committed Details | Review

Comment 1 Rui Matos 2017-08-07 14:11:53 UTC
Created attachment 357115 [details] [review]
display: Refactor night light widget instantiation

We'll need multiple instances of this widget in the new panel
design. This makes it possible.
Comment 2 Rui Matos 2017-08-07 14:11:59 UTC
Created attachment 357116 [details] [review]
display: Add some signals to the new configuration API

These will be useful to keep track of changes across different places
in the new UI.
Comment 3 Rui Matos 2017-08-07 14:12:05 UTC
Created attachment 357117 [details] [review]
display-config-dbus: Consider interlaced flag for similar modes

Otherwise we could end up picking an interlaced mode when we want a
non-interlaced one or vice-versa since they might have equal
refresh rates.
Comment 4 Rui Matos 2017-08-07 14:12:12 UTC
Created attachment 357118 [details] [review]
shell: Add GtkListBox/Row derived types that do single row activations

We often use rows representing different things in the same list
box. In these cases it's often desirable to have rows emitting their
own activation signals instead of having a single handler for the
whole list box that dispatches according to the activated row.
Comment 5 Rui Matos 2017-08-07 14:12:18 UTC
Created attachment 357119 [details] [review]
display: Re-design the panel

This implements most of the new Display panel re-design by Allan
Day.

Left out for now is brightness setting which still is in the
Power panel because the plumbing layers don't yet associate backlights
with outputs.

Also left out is the presentation mode and trimming of options due to
hardware constraints since we don't have a mutter implementation for
those yet.
Comment 6 Rui Matos 2017-08-09 17:38:38 UTC
Pushing this for now. We'll iterate further in separate bugs.

Attachment 357115 [details] pushed as 9b0cf33 - display: Refactor night light widget instantiation
Attachment 357116 [details] pushed as 7c89e30 - display: Add some signals to the new configuration API
Attachment 357117 [details] pushed as 353236b - display-config-dbus: Consider interlaced flag for similar modes
Attachment 357118 [details] pushed as ddd2d5c - shell: Add GtkListBox/Row derived types that do single row activations
Attachment 357119 [details] pushed as c0f686b - display: Re-design the panel