GNOME Bugzilla – Bug 785934
Find next with ctrl-g not working
Last modified: 2017-08-07 19:16:49 UTC
When editing a file, start searching text with ctrl-f. Then either: - Press enter to validate search and hide the little search window - Leave it open Hit ctrl-G and nothing happens at all in both cases. Tested with PHP files, Javascript files and Python files.
Hrmm, I think this might be due to a performance improvement I made to avoid keeping the GtkSourceSearchSettings/Context around when the search box is not visible. I would expect it to work when the search box is visible though. Hrmm...
Until I get this fixed, a temporarily workflow change of using up/down on your keyboard while focused in the search box results in the expected movements.
Created attachment 357135 [details] [review] editor: fix search movements while focused in search entry The GtkSearchEntry registers keybindings for ctrl+g/ctrl+shift+g to emit the previous-match/next-match signals. We need to connect those to our action implementations.
Comment on attachment 357135 [details] [review] editor: fix search movements while focused in search entry Attachment 357135 [details] pushed as fca6e80 - editor: fix search movements while focused in search entry
Created attachment 357138 [details] [review] editor: keep search context around when there are matches We might need to keep the search context around so that we can perform next/previous match actions via keybindings. That adds a bit of overhead in some cases, so we try to detect a few of those and still cleanup the context when possible.
Attachment 357138 [details] pushed as ac7b8f3 - editor: keep search context around when there are matches